Added a new run time protection for Full Sim

[civanch]

PR description:

Added extra check for run time if number of steps exceed limit 10000. This allows to fix tracking for FTFP_BERT_EMZ Physics List used as an alternative for simulation of HGCal. Should not affect the default Physics List FTFP_FTFP_EMM.

PR validation:

private

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33746/22691

ERROR: Build errors found during clang-tidy run.

SimG4Core/Application/src/SteppingAction.cc:38:37: error: use of undeclared identifier 'int32' [clang-diagnostic-error]
  maxNumberOfSteps = p.getParameter<int32>("MaxNumberOfSteps");
                                    ^
SimG4Core/Application/src/SteppingAction.cc:50:36: error: use of undeclared identifier 'MaxNumberOfSteps'; did you mean 'maxNumberOfSteps'? [clang-diagnostic-error]
      << " MaxNumberOfSteps = " << MaxNumberOfSteps;
                                   ^~~~~~~~~~~~~~~~
                                   maxNumberOfSteps
--
SimG4Core/Application/src/SteppingAction.cc:106:75: error: expected ')' [clang-diagnostic-error]
  if (sAlive == tstat && edm::isNotFinite(aStep->GetTotalEnergyDeposit()) {
                                                                          ^
SimG4Core/Application/src/SteppingAction.cc:106:6: note: to match this '('
--
SimG4Core/Application/src/SteppingAction.cc:188:1: error: expected statement [clang-diagnostic-error]
}
^
Suppressed 891 warnings (890 in non-user code, 1 with check filters).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33746/22693

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master.

It involves the following packages:

SimG4Core/Application

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @cvuosalo, @rovere, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[civanch]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-578168/15126/summary.html
COMMIT: e2cf1e2
CMSSW: CMSSW_12_0_X_2021-05-16-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33746/15126/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6047 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2648242
• DQMHistoTests: Total failures: 12135
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2636085
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.063 KiB( 36 files compared)
• DQMHistoSizes: changed ( 10224.0 ): 0.063 KiB SiStrip/MechanicalView
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: found differences in 2 / 36 workflows

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33746/22698

• This PR adds an extra 24KB to repository

[cmsbuild]

Pull request #33746 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

[civanch]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-578168/15131/summary.html
COMMIT: 6a41de3
CMSSW: CMSSW_12_0_X_2021-05-16-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33746/15131/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2648242
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2648213
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1