Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix RPCSeedGenerator wrong nullptr check #33753

Merged
merged 1 commit into from May 18, 2021
Merged

bugfix RPCSeedGenerator wrong nullptr check #33753

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions RecoMuon/MuonSeedGenerator/src/RPCSeedOverlapper.cc
View file
Open in desktop
Expand Up @@ -36,7 +36,7 @@ void RPCSeedOverlapper::unsetIO() { isIOset = false; }
void RPCSeedOverlapper::setGeometry(const RPCGeometry &iGeom) { rpcGeometry = &iGeom; }

void RPCSeedOverlapper::run() {
if (isConfigured == false || isIOset == false || rpcGeometry != nullptr) {
if (isConfigured == false || isIOset == false || rpcGeometry == nullptr) {
cout << "Configuration or IO is not set yet" << endl;
return;
}
Expand Down Expand Up @@ -167,7 +167,7 @@ bool RPCSeedOverlapper::isShareHit(const std::vector<TrackingRecHit const *> &re
GlobalPoint gpos1 = rpcroll1->toGlobal(lpos1);
cout << "The hit's position: " << gpos1.x() << ", " << gpos1.y() << ", " << gpos1.z() << endl;
for (auto const &recHit : recHits) {
cout << "Checking the " << n << " th recHit from tempRecHits" << endl;
cout << "Checking the " << (n++) << " th recHit from tempRecHits" << endl;
LocalPoint lpos2 = recHit->localPosition();
DetId RPCId2 = recHit->geographicalId();
const GeomDetUnit *rpcroll2 = rpcGeometry.idToDetUnit(RPCId2);
Expand Down