Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix valEmtfStage2Digis for unpacked GEM clusters in GEN-SIM-RAW [11_3_X] #33772

Merged
merged 1 commit into from May 19, 2021
Merged

Fix valEmtfStage2Digis for unpacked GEM clusters in GEN-SIM-RAW [11_3_X] #33772

merged 1 commit into from May 19, 2021

Conversation

dildick
Copy link
Contributor

@dildick dildick commented May 18, 2021

PR description:

In response to issue #32634. This would allow the dqmoffline to run on GEN-SIM-RAW in Run-3 scenarios with GEMs included. Previously, valEmtfStage2Digis crashed because it could not find simMuonGEMPadDigiClusters. That is expected. A solution is provided where the GEM trigger primitive producers are run on unpacked GEM digis in GEN-SIM-RAW. Those GEM TP producers have prefixes valMuon. valMuonGEMPadDigiClusters may be replaced with emtfStage2Digis once the EMTF unpacker has been updated for GEM TPs in data and the collection is available in the event.

PR validation:

Code compiles.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #33694 requested by @silviodonato

Before submitting your pull requests, make sure you followed this checklist:

@cmsbuild cmsbuild added this to the CMSSW_11_3_X milestone May 18, 2021
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dildick (Sven Dildick) for CMSSW_11_3_X.

It involves the following packages:

DQM/L1TMonitor

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e9373f/15177/summary.html
COMMIT: cd388c9
CMSSW: CMSSW_11_3_X_2021-05-18-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33772/15177/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2877046
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2877023
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1
Tested in Online DQM at P5

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@dildick
Copy link
Contributor Author

dildick commented May 19, 2021

Thanks Javier!

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a9cad70 into cms-sw:CMSSW_11_3_X May 19, 2021
@dildick dildick deleted the from-CMSSW_11_3_X_2021-05-18-1100-valEmtfStage2Digis-unpacked-GEM-clusters branch May 20, 2021 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants