Remove dead assignments or initializations in a few Calibration packages

[perrotta]

PR description:

It fixes a few dead assignments that were pointed out by the static analyzer.
The warnings raised by the static analizer may be useful in identifying possible bugs in the code: it is therefore advisable to remove as many of those warnings as possible, in particular when their solution is rather trivial as in the present case.

PR validation:

It builds

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33791/22766

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Calibration/IsolatedParticles/plugins/IsoTrackCalibration.cc modified in PR(s): Include the updated header from Geometry/Records instead of the obsolete one #33784

[cmsbuild]

A new Pull Request was created by @perrotta for master.

It involves the following packages:

Calibration/EcalCalibAlgos
Calibration/IsolatedParticles
Calibration/Tools

@malbouis, @yuanchao, @cmsbuild, @tlampen, @pohsun, @francescobrivio can you please review it and eventually sign? Thanks.
@rchatter, @tocheng, @argiro, @thomreis, @simonepigazzini, @mmusich this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-01bb6d/15199/summary.html
COMMIT: f9bba61
CMSSW: CMSSW_12_0_X_2021-05-19-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33791/15199/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2648902
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2648873
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 36 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[yuanchao]

+1

• remove dead assignments or initializations (technical)
• matrix tests and unit tests passed
• build warnings are not of the PR

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1