Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upt invariant mass backport 11 3 x #33800

Merged

Conversation

cavana
Copy link
Contributor

@cavana cavana commented May 20, 2021

PR description:

This PR is a backport from CMSSW_12_0_X which provides a software implementation of the invariant mass correlation condition involving unconstrained pT for displaced muons in the uGT emulator.

No changes in output are expected.

PR validation:

This PR has been validated by the following:
(1) all code changes have been confirmed to compile correctly using
(2) all code changes have been confirmed to execute properly by producing test vectors, which agree with the uGT firmware.
(3) all code changes have been confirmed to execute properly using "runTheMatrix.py -l 11634.0"

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is a backport of PR 33708 (#33708), and is needed for the June MWGR.

Before submitting your pull requests, make sure you followed this checklist:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @cavana (Richard Cavanaugh) for CMSSW_11_3_X.

It involves the following packages:

L1Trigger/L1TGlobal

@cmsbuild, @rekovic, @cecilecaillol can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cecilecaillol
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d1b60d/15229/summary.html
COMMIT: d268e8b
CMSSW: CMSSW_11_3_X_2021-05-20-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33800/15229/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2877046
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2877023
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@cecilecaillol
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented May 21, 2021

+1

@cmsbuild cmsbuild merged commit 6915d7e into cms-sw:CMSSW_11_3_X May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants