Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L1T backport HPS taus #33807

Merged
merged 8 commits into from May 22, 2021

Conversation

cecilecaillol
Copy link
Contributor

PR description:

Implement HPS taus at trigger levl. Needed for HLT TDR

PR validation:

Backport of #33681

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #33681

sandeepbhowmik1 and others added 8 commits May 21, 2021 12:17
(cherry picked from commit 8f55d73)
(cherry picked from commit 0aceacf)
(cherry picked from commit a30f47c)
(cherry picked from commit d462083)
(cherry picked from commit 21829a0)
(cherry picked from commit 85d4e5e)
(cherry picked from commit 391723c)
(cherry picked from commit d13223e)
(cherry picked from commit ad7e27c)
(cherry picked from commit 6bdd8e8)
(cherry picked from commit 0f621c5)
(cherry picked from commit 196fa70)
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @cecilecaillol for CMSSW_11_1_X.

It involves the following packages:

DataFormats/L1TParticleFlow
L1Trigger/Phase2L1Taus

@cmsbuild, @rekovic, @srimanob, @cecilecaillol, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @rovere this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cecilecaillol
Copy link
Contributor Author

please test

@cecilecaillol
Copy link
Contributor Author

+l1

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-066e48/15236/summary.html
COMMIT: f8d4799
CMSSW: CMSSW_11_1_X_2021-05-16-0000/slc7_amd64_gcc820
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33807/15236/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2784828
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2784777
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 31 edm output root files, 36 DQM output files
  • TriggerResults: no differences found

@cecilecaillol
Copy link
Contributor Author

@fwyzard This is the backport with HPS taus

@srimanob
Copy link
Contributor

backport

@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented May 22, 2021

+1

@cmsbuild cmsbuild merged commit a339eb1 into cms-sw:CMSSW_11_1_X May 22, 2021
@fwyzard
Copy link
Contributor

fwyzard commented May 24, 2021

@fwyzard This is the backport with HPS taus

thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants