Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed esConsumes call in L1TriggerJSONMonitoring #33809

Merged

Conversation

missirol
Copy link
Contributor

@missirol missirol commented May 21, 2021

PR description:

Fix for a bug introduced in #33260: the module L1TriggerJSONMonitoring is now migrated correctly to esConsumes.

Spotted by TSG's FOG group during HLT-validation tests for the next MWGR.

It will need to be backported to 11_3_X.

Attn: @Sam-Harper @mzarucki @gennai

PR validation:

None.

Reproduced the issue seen by FOG, and verified that this update solves it.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33809/22799

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

HLTrigger/JSONMonitoring

@Martin-Grunewald, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor

please test

@missirol
Copy link
Contributor Author

For the validation of this PR: I managed to reproduce the issue seen by FOG (in 11_3_X), and checked that this fix solves it as expected (and no other issue shows up, at least in the test I made). I will open the backport PR to 11_3_X, unless there are objections.

@Sam-Harper
Copy link
Contributor

Thanks Marino! The prompt action is very much appreciated!

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-efa026/15237/summary.html
COMMIT: e8f7edf
CMSSW: CMSSW_12_0_X_2021-05-20-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33809/15237/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2650486
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2650451
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: no differences found

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented May 22, 2021

+1

@cmsbuild cmsbuild merged commit 83ce47e into cms-sw:master May 22, 2021
@missirol missirol deleted the devel_fixESConsumesL1TriggerJSONMonitoring branch March 27, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants