Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utilities cleanup #3381

Merged
merged 16 commits into from Apr 17, 2014
Merged

Utilities cleanup #3381

merged 16 commits into from Apr 17, 2014

Conversation

smorovic
Copy link
Contributor

This pull request contains following fixes/improvements:

  • Several obsolete modules were removed (used previously for testing with fakeBU, but no longer used), cleanup of unused code in EvFDaqDirector.
  • Input source now locks a file on the local filesystem when moving index json files or creating EoL (to prevent race between multiple processes which can result in creating EoL prematurely).
  • Setting correct microstate in several FastMonitoringService callbacks
  • Better handling of SIGINT for tests (noticing shutdown_flag, no longer causing assert due to mismatch in event counting)

@smorovic
* cleanup of unused code and obsolete modules
3cdf1b8 
* modified FMS service microstate changes
@smorovic
setting FwkOvh in postModuleEvent (marks transition between two modules)
7378fe8
@smorovic
* checking for presence of EvFDaqDirector in FastMonitoringService
7b2fed4 
* runDir initialization moved to preallocate to avoid dependency in
* orded of construction of FMS and DaqDirector service
@smorovic
* FastMonitor API adjustment
d66e16c 
* fastmon file is written after mon lock is released in FMS
* updated stream module state handling (also added EoL state valid between preStreamEndLumi to postStreamEndLumi)
@smorovic
fix
5582e8f
@smorovic
automatic detection of CMSSW working directory in the input source and
f4fe0e1 
FMS
@smorovic
removing debugging logs
f182589
@smorovic
handle exception on stale deletion of input file
35847a2
@smorovic
print block read statistics
5492a0d
@smorovic
revert accidentally commited change
31538bc
@smorovic
throw error instead of assert in certain cases (effective with SIGINT
08c6c9b 
interruption)
@smorovic
using lock file in all CMSSW processes on a single machine to prevent
f62d1a3 
writing EoL file before all index files of that lumi are moved
@smorovic
use flock as it provides per-fd file locking (suitable for locking from
655eab9 
multiple threads, each using a separate fd)
@smorovic
cleanup of old fake BU output module which is no longer usable
58d611f 
logging with MessageLogger in a few more places
@smorovic
Merge branch 'CMSSW_7_1_X' into utilities-cleanup
62e5041
@smorovic
update changelog
60c450c
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smorovic for CMSSW_7_1_X.

Utilities cleanup

It involves the following packages:

EventFilter/Utilities

@mommsen, @cmsbuild, @Degano, @emeschi, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3381/940/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3381/940/summary.html

@ktf
Copy link
Contributor

ktf commented Apr 17, 2014

Assuming Daq is ok. Merging.

ktf added a commit that referenced this pull request Apr 17, 2014
@ktf
Merge pull request #3381 from smorovic/utilities-cleanup
8239b06 
Utilities cleanup
@ktf ktf merged commit 8239b06 into cms-sw:CMSSW_7_1_X Apr 17, 2014
@smorovic smorovic deleted the utilities-cleanup branch October 7, 2014 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available daq-pending pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_7_1_0_pre7
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@smorovic @cmsbuild @ktf