HcalDQM - Correct LED CU List for P5 (online DQM)

[lwang046]

PR description:
Same feature of #33827 solving the calibration channels list error and the histogram y-axis limits, on top of CMSSW_11_3_0 intended for P5 (online DQM)

PR validation:
runTheMatrix.py -l limited -i all --ibeos okay

[cmsbuild]

A new Pull Request was created by @lwang046 for CMSSW_11_3_X.

It involves the following packages:

DQM/HcalCommon
DQM/HcalTasks

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@abdoulline, @DryRun this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b62035/15299/summary.html
COMMIT: 6a2ecc5
CMSSW: CMSSW_11_3_X_2021-05-24-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33838/15299/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2877742
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2877717
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 11093.313 KiB( 37 files compared)
• DQMHistoSizes: changed ( 1000.0,... ): 385.352 KiB Hcal/DigiTask
• DQMHistoSizes: changed ( 1000.0,... ): 10.273 KiB Hcal/RecHitTask
• DQMHistoSizes: changed ( 1000.0,... ): 2.031 KiB Hcal/TPTask
• DQMHistoSizes: changed ( 1000.0,... ): 0.012 KiB Hcal/RunInfo
• DQMHistoSizes: changed ( 10024.0,... ): 385.441 KiB Hcal/DigiTask
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[pmandrik]

Dear @lwang046 ,

please find the crash log file from DQM^2 in the attachment [0]. While the new book1DD function from your PR deals with TH1D, it is looks like there are still some MonitorElement::getTH1F() calls in the code [1].

Best regards, Petr

[0] 33838.txt
[1]

cmssw/DQM/HcalTasks/plugins/HcalOnlineHarvesting.cc

Lines 136 to 156 in a99211b

	if (meOccupancy_HF_depth && meOccupancyNoTDC_HF_depth && meOccupancy_HF_ieta && meOccupancyNoTDC_HF_ieta) {
	TH2F* hOccupancy_HF_depth = meOccupancy_HF_depth->getTH2F();
	TH2F* hOccupancyNoTDC_HF_depth = meOccupancyNoTDC_HF_depth->getTH2F();
	TH1F* hOccupancy_HF_ieta = meOccupancy_HF_ieta->getTH1F();
	TH1F* hOccupancyNoTDC_HF_ieta = meOccupancyNoTDC_HF_ieta->getTH1F();
	TH2F* hEfficiency_HF_depth = (TH2F*)hOccupancy_HF_depth->Clone();
	hEfficiency_HF_depth->Divide(hOccupancyNoTDC_HF_depth);
	TH1F* hEfficiency_HF_ieta = (TH1F*)hOccupancy_HF_ieta->Clone();
	hEfficiency_HF_ieta->Divide(hOccupancyNoTDC_HF_ieta);
	ib.setCurrentFolder("Hcal/TPTask");
	MonitorElement* meEfficiency_HF_depth = ib.book2D("TDCCutEfficiency_depth", hEfficiency_HF_depth);
	meEfficiency_HF_depth->setEfficiencyFlag();
	MonitorElement* meEfficiency_HF_ieta = ib.book1D("TDCCutEfficiency_ieta", hEfficiency_HF_ieta);
	meEfficiency_HF_ieta->setEfficiencyFlag();
	delete hEfficiency_HF_depth;
	delete hEfficiency_HF_ieta;
	}

[cmsbuild]

Pull request #33838 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please check and sign again.

[lwang046]

Hi @pmandrik, thank you very much for spotting this! I have corrected them with getTH1D() calls

[jfernan2]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b62035/15338/summary.html
COMMIT: 086bbb3
CMSSW: CMSSW_11_3_X_2021-05-26-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33838/15338/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

• No significant changes to the logs found
• Reco comparison results: 1272 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2877742
• DQMHistoTests: Total failures: 3687
• DQMHistoTests: Total nulls: 20
• DQMHistoTests: Total successes: 2874013
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 11139.74 KiB( 37 files compared)
• DQMHistoSizes: changed ( 1000.0,... ): 385.363 KiB Hcal/DigiTask
• DQMHistoSizes: changed ( 1000.0,... ): 10.285 KiB Hcal/RecHitTask
• DQMHistoSizes: changed ( 1000.0,... ): 2.043 KiB Hcal/TPTask
• DQMHistoSizes: changed ( 1000.0,... ): 0.012 KiB Hcal/RunInfo
• DQMHistoSizes: changed ( 10024.0,... ): 385.453 KiB Hcal/DigiTask
• DQMHistoSizes: changed ( 140.53 ): 44.531 KiB Hcal/DigiRunHarvesting
• DQMHistoSizes: changed ( 140.53 ): 1.172 KiB RPC/DCSInfo
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1
Tested succesfully in Online DQM at P5 playback

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1

Tested succesfully in Online DQM at P5 playback