Fix fatJetTable genJetAK8Idx matching #33839

laurenhay · 2021-05-25T18:59:55Z

PR description:

Fixes issue where the GenJetAK8IDx matching did not match the corresponding GenJetAK8Table id's because of a difference in pT cut between the collections being referenced https://hypernews.cern.ch/HyperNews/CMS/get/JetMET/2103.htm

PR validation:

Validated on file in question in 10_6_19_patch2. Could not find any files with the same issue present in the 12 series.
https://cmsweb.cern.ch/das/request?instance=prod/global&input=dataset+file%3D%2Fstore%2Fmc%2FRunIISummer19UL17NanoAODv2%2FTTToHadronic_TuneCP5_13TeV-powheg-pythia8%2FNANOAODSIM%2F106X_mc2017_realistic_v8-v1%2F280000%2F1FA6BD39-B319-C143-92BC-13BC01AF4B89.root

if this PR is a backport please specify the original PR and why you need to backport that PR:

NA

cmsbuild · 2021-05-25T19:07:43Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33839/22858

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/python/jets_cff.py modified in PR(s): Including jetId criteria for UL16 #33826, [NanoAOD, JMENanoAOD] Remove jercVars variables, update puId config #33824

cmsbuild · 2021-05-25T19:08:06Z

A new Pull Request was created by @laurenhay for master.

It involves the following packages:

PhysicsTools/NanoAOD

@cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please review it and eventually sign? Thanks.
@gpetruc, @swertz this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

mariadalfonso · 2021-05-26T09:26:16Z

please test

cmsbuild · 2021-05-26T12:32:37Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d0b602/15312/summary.html
COMMIT: a039dc0
CMSSW: CMSSW_12_0_X_2021-05-25-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33839/15312/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 1 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2650486
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2650463
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 155 log files, 37 edm output root files, 37 DQM output files
TriggerResults: no differences found

mariadalfonso · 2021-05-27T12:18:26Z

@laurenhay can you check the samples listed here and report here the "Scan" before and after the fix ?
You should be able to read in 11_2 the mini of 10_6
https://hypernews.cern.ch/HyperNews/CMS/get/JetMET/2103.html

laurenhay · 2021-05-27T18:00:44Z

@laurenhay can you check the samples listed here and report here the "Scan" before and after the fix ?
You should be able to read in 11_2 the mini of 10_6
https://hypernews.cern.ch/HyperNews/CMS/get/JetMET/2103.html

We scanned the file in 10_6_19_patch2 before changes and got the same output Matej saw:

[lahay@cmsdev20 src]$ root -l root://cms-xrd-global.cern.ch//store/mc/RunIISummer19UL17NanoAODv2/TTToHadronic_TuneCP5_13TeV-powheg-pythia8/NANOAODSIM/106X_mc2017_realistic_v8-v1/280000/1FA6BD39-B319-C143-92BC-13BC01AF4B89.root
root [0] 
Attaching file root://cms-xrd-global.cern.ch//store/mc/RunIISummer19UL17NanoAODv2/TTToHadronic_TuneCP5_13TeV-powheg-pythia8/NANOAODSIM/106X_mc2017_realistic_v8-v1/280000/1FA6BD39-B319-C143-92BC-13BC01AF4B89.root as _file0...
(TFile *) 0x55a2cf0
root [1] Events->Scan("FatJet_genJetAK8Idx[0]:nGenJetAK8","FatJet_genJetAK8Idx[0]>nGenJetAK8 ")
************************************
*    Row   * FatJet_ge * nGenJetAK *
************************************
*      149 *         2 *         0 *
*      561 *         3 *         2 *
*     2134 *         2 *         1 *
*     2939 *         5 *         3 *
*     9582 *         3 *         0 *
*    11441 *         3 *         2 *
*    16619 *         3 *         2 *
*    17807 *         2 *         0 *
...

After the change, I reproduced a subset of the events using this cmsDriver command:

cmsDriver.py --python_filename TOP-RunIISummer19UL17NanoAODv2-00091_1_cfg.py --eventcontent NANOAODSIM --customise Configuration/DataProcessing/Utils.addMonitoring --datatier NANOAODSIM --fileout file:TOP-RunIISummer19UL17NanoAODv2-00091.root --conditions 106X_mc2017_realistic_v8 --step NANO --filein dbs:/TTToHadronic_TuneCP5_13TeV-powheg-pythia8/RunIISummer19UL17MiniAOD-106X_mc2017_realistic_v6-v4/MINIAODSIM --era Run2_2017,run2_nanoAOD_106Xv1 --no_exec --mc -n 100

And the resulting output from scanning the file was:

[lahay@cmsdev20 src]$ root -l TOP-RunIISummer19UL17NanoAODv2-00091.root 
*** DISPLAY not set, setting it to lxplus734.cern.ch:0.0
root [0] 
Attaching file TOP-RunIISummer19UL17NanoAODv2-00091.root as _file0...
(TFile *) 0x344c970
root [1] Events->Scan("FatJet_genJetAK8Idx[0]:nGenJetAK8","FatJet_genJetAK8Idx[0]>nGenJetAK8 ")
************************************
*    Row   * FatJet_ge * nGenJetAK *
************************************
************************************
==> 0 selected entries
(long long) 0

I tried to reproduce the file and changes in 11_2 (and 12_0) using the auto:run2_mc conditions flag, but I also likely need an eras modifier, but do not see one to use for anything past 10_6.
This is the error when I try to run in an CMSSW version past 10_6:

Traceback (most recent call last):
  File "/cvmfs/cms.cern.ch/slc7_amd64_gcc900/cms/cmssw/CMSSW_11_2_1/bin/slc7_amd64_gcc900/cmsDriver.py", line 56, in <module>
    run()
  File "/cvmfs/cms.cern.ch/slc7_amd64_gcc900/cms/cmssw/CMSSW_11_2_1/bin/slc7_amd64_gcc900/cmsDriver.py", line 28, in run
    configBuilder.prepare()
  File "/cvmfs/cms.cern.ch/slc7_amd64_gcc900/cms/cmssw-patch/CMSSW_11_2_1_patch2/python/Configuration/Applications/ConfigBuilder.py", line 2273, in prepare
    self.pythonCfgCode += self.addCustomise()
  File "/cvmfs/cms.cern.ch/slc7_amd64_gcc900/cms/cmssw-patch/CMSSW_11_2_1_patch2/python/Configuration/Applications/ConfigBuilder.py", line 885, in addCustomise
    self.process=getattr(package,fcn)(self.process)
  File "/build/lahay/CMSSW_11_2_1_patch2/python/PhysicsTools/NanoAOD/nano_cff.py", line 377, in nanoAOD_customizeMC
    process = nanoAOD_recalibrateMETs(process,isData=False)
  File "/build/lahay/CMSSW_11_2_1_patch2/python/PhysicsTools/NanoAOD/nano_cff.py", line 236, in nanoAOD_recalibrateMETs
    getJetMCFlavour=False
  File "/cvmfs/cms.cern.ch/slc7_amd64_gcc900/cms/cmssw-patch/CMSSW_11_2_1_patch2/python/PhysicsTools/PatAlgos/tools/jetTools.py", line 1057, in __call__
    self.apply(process)
  File "/cvmfs/cms.cern.ch/slc7_amd64_gcc900/cms/cmssw-patch/CMSSW_11_2_1_patch2/python/PhysicsTools/PatAlgos/tools/ConfigToolBase.py", line 71, in apply
    self.toolCode(process)
  File "/cvmfs/cms.cern.ch/slc7_amd64_gcc900/cms/cmssw-patch/CMSSW_11_2_1_patch2/python/PhysicsTools/PatAlgos/tools/jetTools.py", line 1172, in toolCode
    _newPatJets.genJetMatch.setModuleLabel('patJetGenJetMatch'+_labelName+postfix)
AttributeError: 'EDProducer' object has no attribute 'genJetMatch'

(@rappoccio )

mariadalfonso · 2021-06-01T15:18:43Z

from local tests we have error of this type
https://gitlab.cern.ch/cms-nanoAOD/nanoAOD-integration/-/pipelines/2671791/builds

MSG
1848----- Begin Fatal Exception 01-Jun-2021 12:00:47 CEST-----------------------
1849An exception of category 'Configuration' occurred while
1850   [0] Processing  Event run: 1 lumi: 58 event: 5759 stream: 0
1851   [1] Running path 'nanoAOD_step'
1852  [2] Calling method for module SimpleCandidateFlatTableProducer/'fatJetMCTable'
1853Exception Message:
1854m

rappoccio · 2021-06-02T12:55:46Z

Thanks Maria. @laurenhay is relocating to CERN yesterday and today so we will get it up ASAP.

rappoccio · 2021-06-02T19:35:41Z

PhysicsTools/NanoAOD/python/jets_cff.py

@@ -668,7 +668,7 @@
        nBHadrons = Var("jetFlavourInfo().getbHadrons().size()", "uint8", doc="number of b-hadrons"),
        nCHadrons = Var("jetFlavourInfo().getcHadrons().size()", "uint8", doc="number of c-hadrons"),
        hadronFlavour = Var("hadronFlavour()", int, doc="flavour from hadron ghost clustering"),
-        genJetAK8Idx = Var("?genJetFwdRef().backRef().isNonnull()?genJetFwdRef().backRef().key():-1", int, doc="index of matched gen AK8 jet"),
+        genJetAK8Idx = Var("?genJetFwdRef().backRef().pt() > 100. && genJetFwdRef().backRef().isNonnull()?genJetFwdRef().backRef().key():-1", int, doc="index of matched gen AK8 jet"),


Fix is trivial here, just need to switch order:

genJetFwdRef().backRef().isNonnull() && genJetFwdRef().backRef().pt() > 100.

cmsbuild · 2021-06-02T23:13:22Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33839/23042

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/python/jets_cff.py modified in PR(s): Adding UL16 PUID and fixing QGL values in nanoAOD #33925

mariadalfonso · 2021-06-03T20:22:50Z

please test

cmsbuild · 2021-06-04T00:02:41Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d0b602/15623/summary.html
COMMIT: d27e7e3
CMSSW: CMSSW_12_0_X_2021-06-03-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33839/15623/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 5 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2650486
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2650463
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 155 log files, 37 edm output root files, 37 DQM output files
TriggerResults: no differences found

mariadalfonso · 2021-06-04T12:48:58Z

large stat runs now successfully

NANO changes:

particleNetMD and rawDeepTau2017v2p1VSmu are known non reproducibility issues related to the ML
the nanoaodFlatTable_fatJetMCTable__DQM_obj_ints__genJetAK8Idx minimally change and is inline with the scope of this PR.

There are miniAOD changes: this should not happen !
this is related to the slimmedAK8, so might be that the gen-matching sequence in MINI and NANO talk and the gen ref doesn't match anymore
@slava77 @perrotta @jpata do you have any insight ?

rappoccio · 2021-06-04T13:02:32Z

this is related to the slimmedAK8, so might be that the gen-matching sequence in MINI and NANO talk and the gen ref doesn't match anymore

Wow, this is really surprising to me. Can you point me to the changes?

mariadalfonso · 2021-06-04T13:29:27Z

this is related to the slimmedAK8, so might be that the gen-matching sequence in MINI and NANO talk and the gen ref doesn't match anymore

Wow, this is really surprising to me. Can you point me to the changes?

https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_0_X_2021-06-03-1100+d0b602/43200/validateJR/all_mini_OldVSNew_TTbarwf25p0/

rappoccio · 2021-06-04T13:41:55Z

Bizarre. The changes are in the pair discriminator vector, which was clearly not touched at all. Is there another change that was somehow picked up by this test?

mariadalfonso · 2021-06-05T08:17:41Z

please test

(let's check if the miniAOD changes are reproducible)

cmsbuild · 2021-06-05T12:00:01Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d0b602/15670/summary.html
COMMIT: d27e7e3
CMSSW: CMSSW_12_0_X_2021-06-04-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33839/15670/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2650486
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2650457
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 36 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 155 log files, 37 edm output root files, 37 DQM output files
TriggerResults: no differences found

mariadalfonso · 2021-06-05T15:16:28Z

the miniAOD changes of previous tests are not reproducible
#33839 (comment)
now only changes expected for the nanoAOD genJetAK8Idx

mariadalfonso · 2021-06-05T15:17:24Z

+xpog

cmsbuild · 2021-06-05T15:17:44Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

mariadalfonso · 2021-06-05T15:17:51Z

@laurenhay please prepare the backport to 10_6_X

qliphy · 2021-06-06T01:45:09Z

+1

cmsbuild added this to the CMSSW_12_0_X milestone May 25, 2021

cmsbuild added code-checks-pending orp-pending pending-signatures tests-pending xpog-pending labels May 25, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels May 25, 2021

cmsbuild added tests-started and removed tests-pending labels May 26, 2021

mariadalfonso mentioned this pull request May 26, 2021

features for V9 nanoAOD cms-nanoAOD/cmssw#555

Closed

55 tasks

cmsbuild added tests-approved and removed tests-started labels May 26, 2021

cmsbuild mentioned this pull request May 27, 2021

Including jetId criteria for UL16 #33826

Merged

cmsbuild mentioned this pull request Jun 1, 2021

Adding UL16 PUID and fixing QGL values in nanoAOD #33925

Merged

rappoccio reviewed Jun 2, 2021

View reviewed changes

cmsbuild added code-checks-pending tests-pending and removed code-checks-approved tests-approved labels Jun 2, 2021

cmsbuild removed the code-checks-pending label Jun 2, 2021

cmsbuild added tests-started and removed tests-pending labels Jun 3, 2021

cmsbuild added tests-approved and removed tests-started labels Jun 4, 2021

cmsbuild added tests-started and removed tests-approved labels Jun 5, 2021

cmsbuild added tests-approved and removed tests-started labels Jun 5, 2021

cmsbuild added fully-signed xpog-approved and removed pending-signatures xpog-pending labels Jun 5, 2021

cmsbuild added orp-approved and removed orp-pending labels Jun 6, 2021

cmsbuild merged commit 6d27aa7 into cms-sw:master Jun 6, 2021

laurenhay mentioned this pull request Jun 6, 2021

Backport of fix for genJetAK8ID matching in fatJetMCTable #33990

Merged

swertz mentioned this pull request Mar 13, 2023

[Nano] Fix JetTable genJetIdx matching #41039

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix fatJetTable genJetAK8Idx matching #33839

Fix fatJetTable genJetAK8Idx matching #33839

laurenhay commented May 25, 2021

cmsbuild commented May 25, 2021

cmsbuild commented May 25, 2021

mariadalfonso commented May 26, 2021

cmsbuild commented May 26, 2021

mariadalfonso commented May 27, 2021

laurenhay commented May 27, 2021

mariadalfonso commented Jun 1, 2021

rappoccio commented Jun 2, 2021

rappoccio Jun 2, 2021

cmsbuild commented Jun 2, 2021

mariadalfonso commented Jun 3, 2021

cmsbuild commented Jun 4, 2021

mariadalfonso commented Jun 4, 2021

rappoccio commented Jun 4, 2021

mariadalfonso commented Jun 4, 2021

rappoccio commented Jun 4, 2021

mariadalfonso commented Jun 5, 2021

cmsbuild commented Jun 5, 2021

mariadalfonso commented Jun 5, 2021 •

edited

mariadalfonso commented Jun 5, 2021

cmsbuild commented Jun 5, 2021

mariadalfonso commented Jun 5, 2021

qliphy commented Jun 6, 2021

Fix fatJetTable genJetAK8Idx matching #33839

Fix fatJetTable genJetAK8Idx matching #33839

Conversation

laurenhay commented May 25, 2021

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented May 25, 2021

cmsbuild commented May 25, 2021

mariadalfonso commented May 26, 2021

cmsbuild commented May 26, 2021

Comparison Summary

mariadalfonso commented May 27, 2021

laurenhay commented May 27, 2021

mariadalfonso commented Jun 1, 2021

rappoccio commented Jun 2, 2021

rappoccio Jun 2, 2021

Choose a reason for hiding this comment

cmsbuild commented Jun 2, 2021

mariadalfonso commented Jun 3, 2021

cmsbuild commented Jun 4, 2021

Comparison Summary

mariadalfonso commented Jun 4, 2021

rappoccio commented Jun 4, 2021

mariadalfonso commented Jun 4, 2021

rappoccio commented Jun 4, 2021

mariadalfonso commented Jun 5, 2021

cmsbuild commented Jun 5, 2021

Comparison Summary

mariadalfonso commented Jun 5, 2021 • edited

mariadalfonso commented Jun 5, 2021

cmsbuild commented Jun 5, 2021

mariadalfonso commented Jun 5, 2021

qliphy commented Jun 6, 2021

mariadalfonso commented Jun 5, 2021 •

edited