bug-fix for infinite loop in MuonSimClassifier.cc [94X backport]

[silviodonato]

PR description:

Backport of #28802 to 94X. This infinite loop blocked MUO-RunIIFall17GS-00025

PR validation:

This PR fixes

cmsDriver.py  --python_filename MUO-RunIIFall17DRStdmix-00026_2_cfg.py --eventcontent AODSIM --customise Configuration/DataProcessing/Utils.addMonitoring --datatier AODSIM --fileout file:MUO-RunIIFall17DRStdmix-00026.root --conditions 94X_mc2017_realistic_MuonTrackFix_01 --step RAW2DIGI,L1Reco,RECO,RECOSIM,EI --geometry DB:Extended --filein file:MUO-RunIIFall17DRStdmix-00026_0.root --era Run2_2017 --mc

This command was taken from PdmV recipes to reproduce the error

- GS: 
wget https://cms-pdmv.cern.ch/mcm/public/restapi/requests/get_test/MUO-RunIIFall17GS-00025

edit it to have 100 events (NEVENTS)

source it

it will produce 13 events

- DR: 
wget https://cms-pdmv.cern.ch/mcm/public/restapi/requests/get_test/MUO-RunIIFall17DRStdmix-00026

edit to run 13 events

source it (this is nopu, so no need to set grid env)

[cmsbuild]

A new Pull Request was created by @silviodonato (Silvio Donato) for CMSSW_9_4_X.

It involves the following packages:

SimMuon/MCTruth

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@HuguesBrun, @battibass, @abbiendi, @jhgoh, @calderona, @sscruz, @Fedespring, @cericeci, @trocino, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[civanch]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c6528e/15381/summary.html
COMMIT: 838f9f1
CMSSW: CMSSW_9_4_X_2021-05-23-0000/slc6_amd64_gcc630
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33862/15381/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2721493
• DQMHistoTests: Total failures: 110
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2721221
• DQMHistoTests: Total skipped: 162
• DQMHistoTests: Total Missing objects: 0
• TriggerResults: no differences found

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1