fix issue with watching Runs and LuminosityBlocks in Calibration/TkAlCaRecoProducers [11.3.X]

[mmusich]

backport or #33866

PR description:

In PR #32432 the classes AlcaBeamSpotHarvester and PCLMetadataWriter have been migrated from legacy EDAnalyzers to edm::one::EDAnalyzer, though not correctly as they need to observe both Run and LuminosityBlock transitions in order to support beginRun|LuminosityBlock and endRun|LuminosityBlockmethods that are doing actual work. This has resulted e.g. in the problem reported in this Tier-0 Hypernew thread.
This PR fixes the issue.

PR validation:

It compiles.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is a backport of PR #33866, needed to support upcoming MWGRs

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_11_3_X.

It involves the following packages:

Calibration/TkAlCaRecoProducers

@malbouis, @yuanchao, @cmsbuild, @tlampen, @pohsun, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @threus, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

type bug-fix

[mmusich]

urgent

[mmusich]

@cmsbuild, please test

[francescobrivio]

I tested this PR with the tarball from Tier0:
/afs/cern.ch/user/c/cmst0/public/PausedJobs/MWGR4-2021/tarballs/job_10713
and now the fwk report FrameworkJobReport.xml correctly ends with the line
<FileName>sqlite_file:promptCalibConditions.db</FileName> as expected.

For reference here are the commands I used:

cmsrel CMSSW_11_3_X_2021-05-27-1100
cd CMSSW_11_3_X_2021-05-27-1100/src
cmsenv
git cms-merge-topic mmusich:fixIssueWithOneAnalyzersCalibTracker_11_3_X
scram b -j 8
cp /afs/cern.ch/user/c/cmst0/public/PausedJobs/MWGR4-2021/tarballs/job_10713/*.tar.gz .
tar -zxvf AlcaHarvest-e8eaad1c-bd46-4474-b94a-d29e627642c6-12-logArchive.tar.gz
cd job/WMTaskSpace/cmsRun1
cmsRun -e PSet.py
grep "promptCalibConditions" FrameworkJobReport.xml 

[francescobrivio]

@mmusich title says [10.3.X] instead of [11.3.X]

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0da234/15358/summary.html
COMMIT: da8266e
CMSSW: CMSSW_11_3_X_2021-05-27-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33867/15358/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2864 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2877742
• DQMHistoTests: Total failures: 5196
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2872524
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: found differences in 1 / 37 workflows

[mmusich]

DQMHistoTests: Total failures: 5196

usual gazillion unrelated differences from the DD4HEP workflow

[francescobrivio]

+alca

• The offending WF 11634.911 (2021 DD4hep ttbar) is commented out in master, but not here in 11_3_X. The changes in this PR are unrelated to DD4hep.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1