Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2 hgc01 #3387

Merged
merged 4 commits into from Apr 19, 2014
Merged

Phase2 hgc01 #3387

merged 4 commits into from Apr 19, 2014

Conversation

bsunanda
Copy link
Contributor

Add topology class for HGCalorimeter - has to revise many things to make compatible numbering in Sim/Digi/Reco level.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for CMSSW_6_2_X_SLHC.

Phase2 hgc01

It involves the following packages:

DataFormats/ForwardDetId
Geometry/CMSCommonData
Geometry/CaloEventSetup
Geometry/CaloTopology
Geometry/HGCalCommonData
Geometry/HGCalSimData
SimG4CMS/Calo

The following packages do not have a category, yet:

DataFormats/ForwardDetId
Geometry/HGCalSimData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@andersonjacob
Copy link
Contributor

merge

passing tests
10000
10200
10400
11200
11400
12000
12800
13000
13600
14600

known failures
12200 Step0-PASSED Step1-FAILED Step2-NOTRUN Step3-NOTRUN 0 16640 0 0
12400 Step0-PASSED Step1-FAILED Step2-NOTRUN Step3-NOTRUN 0 34304 0 0
12600 Step0-PASSED Step1-FAILED Step2-NOTRUN Step3-NOTRUN 0 34304 0 0
13800 Step0-PASSED Step1-FAILED Step2-NOTRUN Step3-NOTRUN 0 34304 0 0
14000 Step0-PASSED Step1-FAILED Step2-NOTRUN Step3-NOTRUN 0 34304 0 0
14200 Step0-PASSED Step1-FAILED Step2-NOTRUN Step3-NOTRUN 0 16640 0 0
14400 Step0-PASSED Step1-FAILED Step2-NOTRUN Step3-NOTRUN 0 16640 0 0

cmsbuild added a commit that referenced this pull request Apr 19, 2014
@cmsbuild cmsbuild merged commit ae8bdf8 into cms-sw:CMSSW_6_2_X_SLHC Apr 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants