implement Concurrent GeneratorFilter technique

[PhyM73]

PR description:

The concurrent version of GeneratorFilter is implemented for GEN workflows. This global module mimics the ConcurrentHadronizerFilter and replicates the Generator for each stream in order to run them concurrently. This only works for thread-friendly hadronizers, decayers, and filters.

• Nothing changed in output; expects improved CPU time.
• None of other PRs or externals it depends upon.
• Add a concurrent module of Pythia8 generator, Pythia8ConcurrentGeneratorFilter.
• Provide a unit test in GeneratorInterface/Pythia8Interface/test/BuildFile.xml and a test file as GeneratorInterface/Core/test/ConcurrentGeneratorFilter_WZ_TuneCP5_13TeV-pythia8_cfg.py.
• #25090(comment).

PR validation:

Tested on BTV-RunIISummer20UL17GEN-00002 with 2, 4, and 8 threads and with 1 and 2 ConcurrentLuminosityBlocks respectively. All of them succeed.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33883/22920

• This PR adds an extra 28KB to repository

• Found files with invalid states:

  • GeneratorInterface/Core/test/ConcurrentGeneratorFilter_WZ_TuneCP5_13TeV-pythia8_cfg.py:
    • Added: cd2ff5a
    • Deleted: fc9f8db

[cmsbuild]

A new Pull Request was created by @PhyM73 (Frank M) for master.

It involves the following packages:

GeneratorInterface/Core
GeneratorInterface/Pythia8Interface

@SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[SiewYan]

please test

[PhyM73]

@makortel @Dr15Jones FYI. : ）

[Dr15Jones]

@PhyM73 Thanks!

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bb2040/15391/summary.html
COMMIT: fc9f8db
CMSSW: CMSSW_12_0_X_2021-05-28-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33883/15391/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2650486
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2650457
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33883/22932

• This PR adds an extra 28KB to repository

• Found files with invalid states:

  • GeneratorInterface/Core/test/ConcurrentGeneratorFilter_WZ_TuneCP5_13TeV-pythia8_cfg.py:
    • Added: cd2ff5a
    • Deleted: fc9f8db

[cmsbuild]

Pull request #33883 was updated. @SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please check and sign again.

[SiewYan]

please test

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33883/23108

• This PR adds an extra 32KB to repository

• Found files with invalid states:

  • GeneratorInterface/Core/test/ConcurrentGeneratorFilter_WZ_TuneCP5_13TeV-pythia8_cfg.py:
    • Added: cd2ff5a
    • Deleted: fc9f8db

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33883/23108/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33883/23108/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33883/23109

• This PR adds an extra 32KB to repository

• Found files with invalid states:

  • GeneratorInterface/Core/test/ConcurrentGeneratorFilter_WZ_TuneCP5_13TeV-pythia8_cfg.py:
    • Added: cd2ff5a
    • Deleted: fc9f8db

[cmsbuild]

Pull request #33883 was updated. @SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please check and sign again.

[SiewYan]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bb2040/15717/summary.html
COMMIT: 6e43c45
CMSSW: CMSSW_12_0_X_2021-06-06-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33883/15717/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2648335
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2648312
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[agrohsje]

+generators

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1