Change PI using literals in DataFormats/Math

[mrodozov]

PR description:

Change literals such that they compile on PPC
see
#33743 (comment)

PR validation:

Compiles on PPC, precision for double is the same as using the "" _pi operator

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33892/22947

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @mrodozov (Mircho Rodozov) for master.

It involves the following packages:

DataFormats/Math

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @fabiocos, @rovere this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mrodozov]

please test

[mrodozov]

please test for slc7_ppc64le_gcc9

[mrodozov]

please test slc7_aarch64_gcc9

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f2e1d1/15419/summary.html
COMMIT: 32bf4b9
CMSSW: CMSSW_12_0_X_2021-05-28-2300/slc7_ppc64le_gcc9
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33892/15419/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test test_PrepareInputDb had ERRORS
---> test test_MpsWorkFlow had ERRORS
---> test gpuVertexFinderByDensity_t had ERRORS
---> test gpuVertexFinderOneKernel_t had ERRORS
and more ...

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f2e1d1/15416/summary.html
COMMIT: 32bf4b9
CMSSW: CMSSW_12_0_X_2021-05-28-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33892/15416/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test SiStripDAQ_O2O_test had ERRORS

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2650486
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2650451
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[slava77]

+reconstruction

for #33892 32bf4b9

• technical
• tests pass and comparisons show no (relevant) differences

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

merge

[qliphy]

SiStripDAQ_O2O_test error already in IB