Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed ParameterSet usage from SimBeamSpotObjects #33916

Merged

Conversation

Dr15Jones
Copy link
Contributor

PR description:

Removed ParameterSet usage from SimBeamSpotObjects. Moved the usage to the only piece of code that used it, BeamProfile2DB.

Updated BeamProfile2DB to be a global::EDAnalyzer with a complete fillDescriptions.

PR validation:

Code compiles.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33916/22986

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

CondFormats/BeamSpotObjects
IOMC/EventVertexGenerators

@malbouis, @civanch, @yuanchao, @mdhildreth, @cmsbuild, @tlampen, @ggovi, @pohsun, @francescobrivio can you please review it and eventually sign? Thanks.
@tocheng, @mmusich, @jan-kaspar, @fabiocos, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7d9a2f/15476/summary.html
COMMIT: 7b1d222
CMSSW: CMSSW_12_0_X_2021-05-31-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33916/15476/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2650486
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2650463
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: no differences found

@ggovi
Copy link
Contributor

ggovi commented May 31, 2021

+1

@civanch
Copy link
Contributor

civanch commented Jun 1, 2021

+1

@yuanchao
Copy link
Contributor

yuanchao commented Jun 2, 2021

+1

  • remove ParameterSet usage and CLHEP to BeamProfile2DB.
  • matrix tests and unit tests passed

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jun 3, 2021

+1

@cmsbuild cmsbuild merged commit 3f59f88 into cms-sw:master Jun 3, 2021
@Dr15Jones Dr15Jones deleted the removeParameterSetFromSimBeamSpotObjects branch June 3, 2021 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants