Moved HFRecalibration to CalibCalorimetry/HcalAlgos

[Dr15Jones]

PR description:

The class is not a data product so does not belong in DataFormats/HcalCalibObjects since it adds additional package dependencies. The new package already hosts the related class HBHERecalibration.

All code using HFRecalibration is already dependent upon CalibCalorimetry/HcalAlgos.

PR validation:

The code compiles.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33918/22989

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

CalibCalorimetry/HcalAlgos
CalibCalorimetry/HcalPlugins
DataFormats/HcalCalibObjects
SimCalorimetry/HcalSimProducers

@malbouis, @civanch, @yuanchao, @mdhildreth, @cmsbuild, @tlampen, @pohsun, @francescobrivio can you please review it and eventually sign? Thanks.
@makortel, @rovere, @tocheng, @mariadalfonso, @abdoulline, @mmusich this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3ae132/15483/summary.html
COMMIT: 15d72c4
CMSSW: CMSSW_12_0_X_2021-05-31-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33918/15483/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2650486
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2650463
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[yuanchao]

+1

• Move HFRecalibration to CalibCalorimetry/HcalAlgos
• matrix tests and unit tests passed
• build warnings not from this PR modification

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1