Merge .h with .cc files in RecoEcal/EgammaClusterProducers

[guitargeek]

PR description:

Part of the series of PRs that merges .h files with the .cc files of the plugins in the RecoEcal subsystem.

This has already been done for the RecoEgamma subsystem (see e.g. #32438, #32613, #32362, #32266, #32259).

It makes maintaining the plugins much easier and also excludes the possibility to wrongly include plugin header files (as happened in Validation/EcalClusters and fixed in the second commit of this PR).

PR validation:

CMSSW compiles.

if this PR is a backport please specify the original PR and why you need to backport that PR:

No backport intended.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33935/23012

• This PR adds an extra 60KB to repository

[cmsbuild]

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

RecoEcal/EgammaClusterProducers
Validation/EcalClusters

@perrotta, @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @slava77, @jpata, @rvenditti can you please review it and eventually sign? Thanks.
@Sam-Harper, @lecriste, @rchatter, @jainshilpi, @rovere, @lgray, @sobhatta, @thomreis, @afiqaize, @simonepigazzini, @argiro, @varuns23, @ram1123 this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-313131/15520/summary.html
COMMIT: ebc065e
CMSSW: CMSSW_12_0_X_2021-06-01-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33935/15520/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS Clang-Tidy warnings: There are Clang-Tidy warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-313131/15520/llvm-analysis/cmsclangtidy.txt for details.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2650486
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2650457
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[jpata]

Was renaming RecoEcal/EgammaClusterProducers/interface/EcalBasicClusterLocalContCorrection.h -> RecoEcal/EgammaClusterProducers/src/EcalBasicClusterLocalContCorrection.h intentional? Shouldn't it become .cc?

[guitargeek]

Yes, that was intentional. EcalBasicClusterLocalContCorrection is not a plugin itself, but a helper class for another plugin. That's why it was separate source and header.

[jpata]

+reconstruction

• technical, no changes expected or observed in the tests

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1