Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport 106X] PUID UL16 and UL16APV training and working points #33940

Merged

Conversation

singh-ramanpreet
Copy link
Contributor

PR description:

PR validation:

FYI: @alefisico @camclean @marinakolosova @mariadalfonso

@cmsbuild cmsbuild added this to the CMSSW_10_6_X milestone Jun 2, 2021
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2021

A new Pull Request was created by @singh-ramanpreet (Ramanpreet Singh) for CMSSW_10_6_X.

It involves the following packages:

RecoJets/JetProducers

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @jdolen, @yslai, @jdamgov, @ahinzmann, @nhanvtran, @gkasieczka, @clelange, @schoef, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mariadalfonso
Copy link
Contributor

test parameters:

pull_request = cms-data/RecoJets-JetProducers#13

@mariadalfonso
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-356194/15543/summary.html
COMMIT: 63ec6d6
CMSSW: CMSSW_10_6_X_2021-06-01-2300/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33940/15543/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215543
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215208
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 143 log files, 29 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

@jpata
Copy link
Contributor

jpata commented Jun 3, 2021

+reconstruction

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2021

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@jpata
Copy link
Contributor

jpata commented Jun 3, 2021

@cms-sw/operations-l2 just to avoid confusion, will the RecoJets-JetProducers tag bump V05-13-00->V05-14-00 for cms-sw/cmsdist:10_6_X happen automatically, or should someone open a PR?

@silviodonato
Copy link
Contributor

@cms-sw/operations-l2 just to avoid confusion, will the RecoJets-JetProducers tag bump V05-13-00->V05-14-00 for cms-sw/cmsdist:10_6_X happen automatically, or should someone open a PR?

someone should make a backport of https://github.com/cms-sw/cmsdist/pull/6961/files

@jpata
Copy link
Contributor

jpata commented Jun 3, 2021

someone should make a backport of https://github.com/cms-sw/cmsdist/pull/6961/files

Just to be clear, do you mean a backport in https://github.com/cms-sw/cmsdist? Which branch there for 10_6_X? And I understand we don't need to do a backport in https://github.com/cms-data/RecoJets-JetProducers, correct?

@qliphy
Copy link
Contributor

qliphy commented Jun 3, 2021

@jpata yes, a cmsdist backport to the branch of IB/CMSSW_10_6_X/gcc700 (to update the version of RecoJets-JetProducers in data/cmsswdata.txt)

jpata added a commit to jpata/cmsdist that referenced this pull request Jun 3, 2021
@jpata
Copy link
Contributor

jpata commented Jun 3, 2021

Thank you for the clarification, I created the cmsdist PR: cms-sw/cmsdist#6977

@singh-ramanpreet
Copy link
Contributor Author

Hi @mariadalfonso
In addition to this backport, do we also need UL16 to be backported to other version of cmssw?

@mariadalfonso
Copy link
Contributor

Hi @mariadalfonso
In addition to this backport, do we also need UL16 to be backported to other version of cmssw?

@singh-ramanpreet master + 10_6 are enough, no need of more back ports

@qliphy
Copy link
Contributor

qliphy commented Jun 4, 2021

+1

@cmsbuild cmsbuild merged commit 4fa80c8 into cms-sw:CMSSW_10_6_X Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants