do not print SiStrip O2O passwords in dbParams_

[quinnanm]

PR description:

Addition to "do not print SiStrip O2O passwords in clear" #33900

prevents SiStripConfigDb.cc (https://github.com/cms-sw/cmssw/blob/CMSSW_12_0_DEVEL_X/OnlineDB/SiStripConfigDb/src/SiStripConfigDb.cc#L124) from printing password

PR validation:

It compiles

if this PR is a backport please specify the original PR and why you need to backport that PR:

backport of #33947

[cmsbuild]

A new Pull Request was created by @quinnanm (Melissa Quinnan) for CMSSW_11_3_X.

It involves the following packages:

OnlineDB/SiStripConfigDb

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@erikbutz, @mmusich this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ee90ac/15556/summary.html
COMMIT: 68ee531
CMSSW: CMSSW_11_3_X_2021-06-02-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33948/15556/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2877742
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2877719
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[mmusich]

test parameters addpkg = CondTools/SiStrip

[mmusich]

@cmsbuild please test

[smuzaffar]

test parameters:

• addpkg = CondTools/SiStrip

[smuzaffar]

@cmsbuild please test
@mmusich , correct format is #33948 (comment)

[mmusich]

@smuzaffar
Why the bot put the +1 sign below #33948 (comment) then?

[smuzaffar]

@smuzaffar
Why the bot put the +1 sign below #33948 (comment) then?

@mmusich, looks like a bug in bot ( https://github.com/cms-sw/cms-bot/blob/master/process_pr.py#L311 ) . It only checks if test parameters is in first line and then it process all other lines. test parameters comment with no parameters on line 2 ( and above) is also a valid comment ( this is used for overriding previously set parameters)

[mmusich]

@smuzaffar OK - thanks.
Based on the logs of your last round of tests we should be finally clear of passwords printed in the logs!

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ee90ac/15569/summary.html
COMMIT: 68ee531
CMSSW: CMSSW_11_3_X_2021-06-02-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33948/15569/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2877742
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2877713
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[ggovi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1