Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not print SiStrip O2O passwords in clear #33900

Merged
merged 1 commit into from May 31, 2021

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented May 31, 2021

PR description:

Title says it all. Do not print Tracker Online DB passwords during O2O execution in clear

PR validation:

It compiles.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport, a backport to all production cycles will be needed.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33900/22969

  • This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33900/22972

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

OnlineDB/SiStripConfigDb

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@erikbutz, @mmusich this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented May 31, 2021

@silviodonato @qliphy can you clarify what are the release still active.
I think to avoid a security breach this needs to be backported in each and every one of them.

@silviodonato
Copy link
Contributor

@mmusich the active branches are
12_0_X
11_3_X
11_2_X
11_1_X
10_6_X
10_3_X
10_2_X
9_4_X
9_3_X
8_0_X
7_1_X
5_3_X

@mmusich
Copy link
Contributor Author

mmusich commented May 31, 2021

@silviodonato @ggovi
I have done backports for the active release branches in which there are SiStrip O2O integrations tests:

12_3_X: #33904
11_2_X: #33905
11_1_X: #33906
10_6_X: #33907
10_3_X: #33908
10_2_X: #33909

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cd40f3/15455/summary.html
COMMIT: 60d2229
CMSSW: CMSSW_12_0_X_2021-05-30-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33900/15455/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2650486
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2650463
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented May 31, 2021

urgent

@silviodonato
Copy link
Contributor

merge
technical fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants