Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed ParameterSet usage from CondFormats/EcalObjects #33956

Merged

Conversation

Dr15Jones
Copy link
Contributor

PR description:

The ParameterSet are now handled by the ES modules.

PR validation:

The code compiles.

The ParameterSet are now handled by the ES modules.
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33956/23037

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2021

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

CondFormats/EcalObjects
RecoLocalCalo/EcalRecProducers

@perrotta, @malbouis, @yuanchao, @tlampen, @cmsbuild, @jpata, @slava77, @ggovi, @pohsun, @francescobrivio can you please review it and eventually sign? Thanks.
@rchatter, @tocheng, @argiro, @apsallid, @thomreis, @simonepigazzini, @mmusich, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d362a5/15573/summary.html
COMMIT: f09f862
CMSSW: CMSSW_12_0_X_2021-06-02-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33956/15573/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d362a5/15573/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d362a5/15573/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2650486
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2650457
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: no differences found

@slava77
Copy link
Contributor

slava77 commented Jun 3, 2021

enable gpu

@slava77
Copy link
Contributor

slava77 commented Jun 3, 2021

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d362a5/15584/summary.html
COMMIT: f09f862
CMSSW: CMSSW_12_0_X_2021-06-02-2300/slc7_amd64_gcc900
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33956/15584/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 4
  • DQMHistoTests: Total histograms compared: 9533
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 9533
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
  • Checked 12 log files, 9 edm output root files, 4 DQM output files
  • TriggerResults: no differences found

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2650486
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2650463
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: no differences found

@yuanchao
Copy link
Contributor

yuanchao commented Jun 3, 2021

+1

  • removed ParameterSet usage
  • matrix and unit tests passed

@ggovi
Copy link
Contributor

ggovi commented Jun 3, 2021

+1

@slava77
Copy link
Contributor

slava77 commented Jun 3, 2021

+reconstruction

for #33956 f09f862

  • code changes are in line with the PR description
  • jenkins tests pass and comparisons with the baseline show no differences (including the GPU part which is modified by this PR)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jun 4, 2021

+1

@cmsbuild cmsbuild merged commit 787113c into cms-sw:master Jun 4, 2021
@Dr15Jones Dr15Jones deleted the removeParameterSetFromEcalObjects branch June 9, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants