Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue with DQMGlobalEDAnalyzer skeleton (mkdqmedanalyzer command) #33957

Merged
merged 1 commit into from Jun 3, 2021

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jun 2, 2021

PR description:

I noticed recently that the code generated with the command:

 mkdqmedanalyzer -author mmusich Test example_global

didn't compile due to the removal of ConcurrentMonitorElement and DQMStore::ConcurrentBooker in #28092.
This PR changes the skeleton in order to generate code that compiles.

PR validation:

Used the command above with this branch and obtained compiling code.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport, no backport needed.

@mmusich
Copy link
Contributor Author

mmusich commented Jun 2, 2021

type bug-fix

@mmusich
Copy link
Contributor Author

mmusich commented Jun 2, 2021

@cms-sw/dqm-l2 FYI

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33957/23038

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2021

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

FWCore/Skeletons

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor

makortel commented Jun 2, 2021

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-58e1a7/15575/summary.html
COMMIT: 845a7a7
CMSSW: CMSSW_12_0_X_2021-06-02-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33957/15575/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2650486
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2650457
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Contributor

makortel commented Jun 3, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jun 3, 2021

+1

@cmsbuild cmsbuild merged commit e2670c9 into cms-sw:master Jun 3, 2021
@mmusich mmusich deleted the fixDQMGlobalEDAnalyzerExample branch June 3, 2021 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants