Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add BeamSpot workflows to Calibration/TkAlCaRecoProducers unit test #33958

Merged
merged 1 commit into from Jun 4, 2021

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jun 3, 2021

PR description:

This is a follow-up of PR #33880 in which a unit test for the AlCaHarvesting / PCLMetadataWriter was adeed.
The BeamSpot workflows are added to the test and some more refinements to the configuration are added.

PR validation:

Run the modified unit tests.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport, no backport is needed.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33958/23045

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2021

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

Calibration/TkAlCaRecoProducers

@malbouis, @yuanchao, @cmsbuild, @tlampen, @pohsun, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @threus, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Jun 3, 2021

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0cd779/15599/summary.html
COMMIT: 56f3561
CMSSW: CMSSW_12_0_X_2021-06-02-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33958/15599/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1264 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2650486
  • DQMHistoTests: Total failures: 3674
  • DQMHistoTests: Total nulls: 20
  • DQMHistoTests: Total successes: 2646770
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -45.707 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 140.53 ): -44.531 KiB Hcal/DigiRunHarvesting
  • DQMHistoSizes: changed ( 140.53 ): -1.172 KiB RPC/DCSInfo
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: no differences found

@yuanchao
Copy link
Contributor

yuanchao commented Jun 4, 2021

+1

  • add BeamSpot workflows (technical)
  • unit tests passed

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jun 4, 2021

+1

@cmsbuild cmsbuild merged commit be1db70 into cms-sw:master Jun 4, 2021
@mmusich mmusich deleted the introduceAlCaHarvestingUnitTest branch June 4, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants