New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove explicit L2MuonProducer_cfi #33968
Remove explicit L2MuonProducer_cfi #33968
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33968/23062
|
A new Pull Request was created by @perrotta for master. It involves the following packages: RecoMuon/L2MuonProducer @perrotta, @cmsbuild, @slava77, @Martin-Grunewald, @fwyzard, @jpata can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ffd903/15622/summary.html Comparison SummarySummary:
|
+1
|
kindly remind @cms-sw/hlt-l2 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Remove explicit L2MuonProducer_cfi: that file was already obsolete (and had the same name as the one implicitly created by the fillDescription method of the producer), and after #33563 got merged it risked to create a cyclic dependences, see #33563 (comment)
PR validation:
It builds