Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit L2MuonProducer_cfi #33968

Merged
merged 1 commit into from Jun 7, 2021

Conversation

perrotta
Copy link
Contributor

@perrotta perrotta commented Jun 3, 2021

PR description:

Remove explicit L2MuonProducer_cfi: that file was already obsolete (and had the same name as the one implicitly created by the fillDescription method of the producer), and after #33563 got merged it risked to create a cyclic dependences, see #33563 (comment)

PR validation:

It builds

@perrotta
Copy link
Contributor Author

perrotta commented Jun 3, 2021

@Martin-Grunewald

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33968/23062

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2021

A new Pull Request was created by @perrotta for master.

It involves the following packages:

RecoMuon/L2MuonProducer

@perrotta, @cmsbuild, @slava77, @Martin-Grunewald, @fwyzard, @jpata can you please review it and eventually sign? Thanks.
@HuguesBrun, @bellan, @abbiendi, @Fedespring, @calderona, @sscruz, @jhgoh, @trocino, @cericeci, @rociovilar this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor Author

perrotta commented Jun 3, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ffd903/15622/summary.html
COMMIT: 0070366
CMSSW: CMSSW_12_0_X_2021-06-03-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33968/15622/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2650486
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2650463
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor Author

perrotta commented Jun 4, 2021

+1

  • Technical removal of a deprecated config
  • Jenkins test pass

@qliphy
Copy link
Contributor

qliphy commented Jun 7, 2021

kindly remind @cms-sw/hlt-l2

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jun 7, 2021

+1

@cmsbuild cmsbuild merged commit ea1df8c into cms-sw:master Jun 7, 2021
@perrotta perrotta deleted the removeExplicitL2MuonProducer_cfi branch June 7, 2021 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants