Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: TrackerTopologyEP added and Warning log file added: backport from 71x #3401

Merged

Conversation

venturia
Copy link
Contributor

This pull request is a back port of #3400

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @venturia for CMSSW_7_0_X.

Bug fix: TrackerTopologyEP added and Warning log file added: backport from 71x

It involves the following packages:

DQM/SiStripMonitorSummary

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@danduggan
Copy link
Contributor

It looks like this PR is failing DQM test 9 (linked from the summary), with a seg fault showing up at postprocessing. Could you check this?

@venturia
Copy link
Contributor Author

Hi,

I know it is a sort of sloppy answer of mine, but it is possible that the seg fault is NOT due to my pull request and it is due to a different problem? My changes are expected to affect only cfg files in the test directory. Otherwise I can help but I need clear instructions on how to reproduce the problem.

On Apr 24, 2014, at 9:36 , danduggan <notifications@github.commailto:notifications@github.com>
wrote:

It looks like this PR is failing DQM test #9#9 (linked from the summary), with a seg fault showing up at postprocessing. Could you check this?


Reply to this email directly or view it on GitHubhttps://github.com//pull/3401#issuecomment-41251674.

@rovere
Copy link
Contributor

rovere commented Apr 24, 2014

@danduggan @venturia @deguio I confirm the offending library seem to be pluginValidationRecoEgammaPlugins.so, nothing related to Andrea's PR.

Is it possible that this test is failing since a while, and went unnoticed .. ?

Ciao,
M.

@danduggan
Copy link
Contributor

Thanks Marco for the clarification. My guess is that it must have been failing for some time, and wasn't noticed because of the infrequency of backports. Something for me to follow up on.

@danduggan
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@deguio
Copy link
Contributor

deguio commented Apr 27, 2014

hello,
this is known and understood in 70X. it wasn't unnoticed. the DQM tests were broken at a certain point and I didn't submit the fix for 70X, but only for 71X.
sorry if this created confusion.

ciao,
F.

(the problem is with the tests which search for the wrong file and not with the PhotonPostProcessor which, by the way, is not protected against missing histos)

davidlange6 added a commit that referenced this pull request Apr 29, 2014
Bug fix: TrackerTopologyEP added and Warning log file added: backport from 71x
@davidlange6 davidlange6 merged commit ac0c28c into cms-sw:CMSSW_7_0_X Apr 29, 2014
@venturia venturia deleted the dqm_sistripmonitorsummary-70x branch May 2, 2014 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants