[RECONSTRUCTION] Apply code-checks/format with misc-definitions-in-headers

[smuzaffar]

code-checks/format applied on full cmssw

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34050/23185

• This PR adds an extra 476KB to repository

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

CommonTools/CandUtils
CommonTools/Clustering1D
CommonTools/ParticleFlow
CommonTools/RecoAlgos
CommonTools/UtilAlgos
CommonTools/Utils
DataFormats/MuonData
DataFormats/PatCandidates
DataFormats/TrackReco
JetMETCorrections/Type1MET
PhysicsTools/ONNXRuntime
PhysicsTools/PatAlgos
PhysicsTools/PatUtils
PhysicsTools/SelectorUtils
RecoBTag/ImpactParameter
RecoBTau/JetTagComputer
RecoEgamma/EgammaTools
RecoJets/FFTJetAlgorithms
RecoLocalCalo/CaloTowersCreator
RecoLocalTracker/SiStripRecHitConverter
RecoMET/METFilters
RecoParticleFlow/PFClusterProducer
RecoPixelVertexing/PixelTriplets
RecoTauTag/RecoTau
RecoTracker/MeasurementDet
RecoTracker/TkDetLayers
RecoTracker/TkHitPairs
RecoTracker/TkMSParametrization
RecoTracker/TkNavigation
RecoTracker/TkSeedGenerator
RecoVertex/GhostTrackFitter
RecoVertex/KalmanVertexFit
RecoVertex/VertexTools
TrackPropagation/RungeKutta
TrackingTools/DetLayers
TrackingTools/GeomPropagators
TrackingTools/GsfTools
TrackingTools/MaterialEffects
TrackingTools/MeasurementDet
TrackingTools/PatternTools
TrackingTools/TrackFitters
TrackingTools/TrajectoryParametrization
TrackingTools/TrajectoryState
TrackingTools/TransientTrack

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@echabert, @rappoccio, @gouskos, @makortel, @felicepantaleo, @jainshilpi, @hatakeyamak, @robervalwalsh, @emilbols, @swozniewski, @mbluj, @ahinzmann, @abbiendi, @varuns23, @seemasharmafnal, @mmarionncern, @HuguesBrun, @JyothsnaKomaragiri, @pieterdavid, @threus, @JanFSchulte, @jhgoh, @lgray, @apsallid, @sscruz, @cericeci, @ferencek, @yduhm, @Sam-Harper, @cbernet, @GiacomoSguazzoni, @rovere, @VinInn, @jdamgov, @bellan, @nhanvtran, @gkasieczka, @schoef, @alesaggio, @ebrondol, @mtosi, @dgulhan, @clelange, @jdolen, @trocino, @riga, @gbenelli, @Fedespring, @calderona, @sobhatta, @lecriste, @afiqaize, @gpetruc, @mariadalfonso, @mmusich, @andrzejnovak, @ram1123 this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0de938/15793/summary.html
COMMIT: 6a5dc2e
CMSSW: CMSSW_12_0_X_2021-06-08-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34050/15793/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS Clang-Tidy warnings: There are Clang-Tidy warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0de938/15793/llvm-analysis/cmsclangtidy.txt for details.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2862520
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2862497
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[slava77]

+reconstruction

for #34050 6a5dc2e

• technical

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1