[VISUALIZATION] Apply code-checks/format with misc-definitions-in-headers

[smuzaffar]

code-checks/format applied on full cmssw

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34054/23188

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

Fireworks/Core

@makortel, @alja, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[alja]

@smuzaffar Thank You!
+1

[makortel]

I'd say -1 though...

[smuzaffar]

agree, we should add

// clang-format off

// clang-format on

around this section

[alja]

@makortel
@smuzaffar
Is there a way to tell formatter to leave out some code?

[makortel]

There is, but we have the same issue on many exetutables in FWCore, so let's figure out a common solution first.

[smuzaffar]

@makortel , I think there is no automatic solution. We do want clang-format to format the code and wrap the lines to 120 chars. I would suggest that so cases like this and few in Core we just wrap the section with

// clang-format off

// clang-format on

[makortel]

@makortel , I think there is no automatic solution. We do want clang-format to format the code and wrap the lines to 120 chars. I would suggest that so cases like this and few in Core we just wrap the section with

// clang-format off

// clang-format on

Ok (pretty much what I was afraid of). How do we proceed in practice? Should we format these sections manually now (that they're not that awful yet) and repeat the automatic formatting, or merge these PRs and format manually afterwards?

[smuzaffar]

@makortel , yes I can fix this PR and one for core ( #34036 ) and revert the formatting changes ( where it is really awful) and add // clang-format off/on around those sections.

[makortel]

Thanks @smuzaffar!

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34054/23210

• This PR adds an extra 24KB to repository

[cmsbuild]

Pull request #34054 was updated. @makortel, @alja, @cmsbuild, @Dr15Jones can you please check and sign again.

[smuzaffar]

please test

[alja]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-899b35/15822/summary.html
COMMIT: 2d9f96c
CMSSW: CMSSW_12_0_X_2021-06-08-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34054/15822/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2862520
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2862497
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[qliphy]

+1