Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test how to do blocking hand-off between TBB and module thread #34084

Merged
merged 14 commits into from Jun 15, 2021
Merged

Test how to do blocking hand-off between TBB and module thread #34084

merged 14 commits into from Jun 15, 2021

Commits on Jun 10, 2021

  1. Added TestServicesOnNonFrameworkThreadsAnalyzer

    @Dr15Jones
    Dr15Jones committed Jun 10, 2021
    Copy the full SHA
    2bbc26b View commit details
    Browse the repository at this point in the history

  2. Removed unused methods from edm::service::MessageLogger 

    Also moved a method only used internally to private section.
    @Dr15Jones
    Dr15Jones committed Jun 10, 2021
    Copy the full SHA
    d8ff91c View commit details
    Browse the repository at this point in the history

  3. Fix naming convention for SummarizeInJobReport method

    @Dr15Jones
    Dr15Jones committed Jun 10, 2021
    Copy the full SHA
    56d7540 View commit details
    Browse the repository at this point in the history

  4. Moved edm::service::MessageLogger to plugins 

    Also moved pset validation class as it is only used by MessageLogger.
    @Dr15Jones
    Dr15Jones committed Jun 10, 2021
    Copy the full SHA
    7c2082a View commit details
    Browse the repository at this point in the history

  5. Updated include guards

    @Dr15Jones
    Dr15Jones committed Jun 10, 2021
    Copy the full SHA
    7740e96 View commit details
    Browse the repository at this point in the history

  6. Added a user callable edm::MessageLogger Service interface 

    This allows properly setting up the MessageLogger for a non-framework controlled thread.
    @Dr15Jones
    Dr15Jones committed Jun 10, 2021
    Copy the full SHA
    9e3c0d8 View commit details
    Browse the repository at this point in the history

  7. Added unit test using TestServicesOnNonFrameworkThreadsAnalyzer

    @Dr15Jones
    Dr15Jones committed Jun 10, 2021
    Copy the full SHA
    291ce4e View commit details
    Browse the repository at this point in the history

  8. Removed unneeded include from FWCore/MessageService

    @Dr15Jones
    Dr15Jones committed Jun 10, 2021
    Copy the full SHA
    0a17d4b View commit details
    Browse the repository at this point in the history

  9. clang does not like final on destructors

    @Dr15Jones
    Dr15Jones committed Jun 10, 2021
    Copy the full SHA
    0a965ce View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2021

  1. Better include guard naming 

    Co-authored-by: Andrea Bocci <andrea.bocci@cern.ch>
    @Dr15Jones @fwyzard
    Dr15Jones and fwyzard committed Jun 11, 2021
    Copy the full SHA
    eb972f5 View commit details
    Browse the repository at this point in the history

  2. drop include path when file is in same directory 

    Co-authored-by: Andrea Bocci <andrea.bocci@cern.ch>
    @Dr15Jones @fwyzard
    Dr15Jones and fwyzard committed Jun 11, 2021
    Copy the full SHA
    64e6fde View commit details
    Browse the repository at this point in the history

  3. Make comment consistent with guard names 

    Co-authored-by: Matti Kortelainen <matti.kortelainen@cern.ch>
    @Dr15Jones @makortel
    Dr15Jones and makortel committed Jun 11, 2021
    Copy the full SHA
    beadab1 View commit details
    Browse the repository at this point in the history

  4. Get header from same directory 

    Co-authored-by: Matti Kortelainen <matti.kortelainen@cern.ch>
    @Dr15Jones @makortel
    Dr15Jones and makortel committed Jun 11, 2021
    Copy the full SHA
    e6135ca View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2021

  1. include from same directory 

    Co-authored-by: Matti Kortelainen <matti.kortelainen@cern.ch>
    @Dr15Jones @makortel
    Dr15Jones and makortel committed Jun 12, 2021
    Copy the full SHA
    54aa65d View commit details
    Browse the repository at this point in the history