Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Remove the packedCandidate to gen associations in miniAOD_customizeAllData #34115

Merged

Conversation

elusian
Copy link

@elusian elusian commented Jun 14, 2021

PR description:

#33996 added two new collections to the MINIAODSIM event content, and the corresponding task. However, if cmsDriver is provided both the MINIAODSIM event content and the --data switch, the prunedGenParticles collection that is used to produce the associations is removed by a customizer and the job crashes due to ProductNotFound.

This PR adds the two new collections to the list of collections to remove with the miniAOD_customizeAllData function, inside the coreTools.py file.

PR validation:

The tests were performed using the scram b runtests inside TauAnalysis/MCEmbeddingTools, which first triggered the issue

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #34113 to fix the issue in #33996

…s to remove when customizing cmsDriver to run on data
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 14, 2021

A new Pull Request was created by @elusian for CMSSW_10_6_X.

It involves the following packages:

PhysicsTools/PatAlgos

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @jdolen, @JyothsnaKomaragiri, @ahinzmann, @schoef, @emilbols, @swozniewski, @jdamgov, @mbluj, @nhanvtran, @gkasieczka, @clelange, @hatakeyamak, @ferencek, @gpetruc, @andrzejnovak, @mariadalfonso, @seemasharmafnal, @mmarionncern this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Jun 14, 2021

test parameters:
addpkg = TauAnalysis/MCEmbeddingTools

@slava77
Copy link
Contributor

slava77 commented Jun 14, 2021

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f3bad3/15944/summary.html
COMMIT: 085dfda
CMSSW: CMSSW_10_6_X_2021-06-14-1100/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34115/15944/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215686
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215351
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 143 log files, 29 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

@slava77
Copy link
Contributor

slava77 commented Jun 16, 2021

backport of #34113

@slava77
Copy link
Contributor

slava77 commented Jun 16, 2021

+reconstruction

for #34115 085dfda

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jun 16, 2021

+1

@cmsbuild cmsbuild merged commit 93cda99 into cms-sw:CMSSW_10_6_X Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants