Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DTDQM Fix to testUnit #34164

Merged
merged 1 commit into from Jun 17, 2021
Merged

DTDQM Fix to testUnit #34164

merged 1 commit into from Jun 17, 2021

Conversation

jfernan2
Copy link
Contributor

@jfernan2 jfernan2 commented Jun 17, 2021

PR description:

This PR fixes IB crash reported on:
https://cmssdt.cern.ch/SDT/cgi-bin/logreader/slc7_amd64_gcc900/CMSSW_12_0_X_2021-06-16-2300/unitTestLogs/DQM/Integration#/
Produced by changes on #34153

PR is used to replace colon by semicolon in python files of the packages

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34164/23372

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jfernan2 for master.

It involves the following packages:

DQM/DTMonitorClient
DQM/DTMonitorModule

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@battibass this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor Author

please test

@smuzaffar
Copy link
Contributor

test parameters:

  • addpkg = DQM/Integration

@smuzaffar
Copy link
Contributor

please test
@jfernan2 , I am restarting the test just to make sure that DQM/Integration is checked out and run the failing unit tests

@Dr15Jones
Copy link
Contributor

Why the change from single quotes to double quotes? In python those are completely equivalent.

@@ -104,7 +104,7 @@
# Local Trigger task for test pulses
from DQM.DTMonitorModule.dtTriggerTask_TP_cfi import *
from DQM.DTMonitorClient.dtLocalTriggerTest_TP_cfi import *
dtTPTriggerTest.hwSources = 'TM'
dtTPTriggerTest.hwSources = ['TM']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two changes in this file are all that is needed to fix the unit tests.

@qliphy qliphy mentioned this pull request Jun 17, 2021
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-157781/16070/summary.html
COMMIT: 7afae8e
CMSSW: CMSSW_12_0_X_2021-06-16-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34164/16070/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2862520
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2862497
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor Author

Why the change from single quotes to double quotes? In python those are completely equivalent.

This has been a misunderstanding from my side sorry... since they are equivalent I suggest taking the PR as it is

@jfernan2
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jun 17, 2021

+1

@cmsbuild cmsbuild merged commit ac5ca81 into cms-sw:master Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants