Fix mistake in muon shower valid flag. Enable showers in L1T (HadronicShowerTrigger-6)

[dildick]

PR description:

Fix mistake in muon shower valid flag. The valid flag was not considering nominal muon showers in-time. I'm also enabling the showers in the sequence for Run-3 scenarios. Only the one-nominal-shower case is enabled for the time being. edmEventSize now shows the shower collections

CSCDetIdCSCShowerDigiMuonDigiCollection_simCscTriggerPrimitiveDigis_Anode_HLT. 331.6 309.2
CSCDetIdCSCShowerDigiMuonDigiCollection_simCscTriggerPrimitiveDigis__HLT. 324.6 302
l1tRegionalMuonShowerBXVector_simEmtfShowers_EMTF_HLT. 312.4 272.4
l1tMuonShowerBXVector_simGmtShowerDigis__HLT. 296.6 256.7

PR validation:

• Tested on Run-3 GEN-SIM-RAW samples
• Tested WF 11634.0
• scram b runtests
• scram b code-format; scram b code-checks

There should be no changes in WFs.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

@kakwok @Nik-Menendez

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34178/23389

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

DataFormats/L1TMuon
DataFormats/L1Trigger
L1Trigger/L1TMuon

@cmsbuild, @rekovic, @cecilecaillol can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @dinyar, @rovere, @kreczko, @thomreis this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cecilecaillol]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22218c/16104/summary.html
COMMIT: 32d3cd2
CMSSW: CMSSW_12_0_X_2021-06-18-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34178/16104/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2785631
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2785602
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[dildick]

Few failures from messagelogger and pixel

[dinyar]

Hi Sven,

I had a very brief look and noticed that there are some GEM-related changes in this PR. I assume this slipped in by mistake?

Cheers,
Dinyar

[dildick]

I fixed it. It's clearer now that showers are enabled through the addition

## hadronic shower trigger for Run-3
from Configuration.Eras.Modifier_run3_common_cff import run3_common
_run3_Shower_SimL1TMuonTask = SimL1TMuonTask.copy()
_run3_Shower_SimL1TMuonTask.add(simEmtfShowers)
_run3_Shower_SimL1TMuonTask.add(simGmtShowerDigis)
(stage2L1Trigger & run3_common).toReplaceWith( SimL1TMuonTask, _run3_Shower_SimL1TMuonTask )

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34178/23398

• This PR adds an extra 12KB to repository

[cmsbuild]

Pull request #34178 was updated. @cmsbuild, @rekovic, @cecilecaillol can you please check and sign again.

[qliphy]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34178/23414

• This PR adds an extra 12KB to repository

[cmsbuild]

Pull request #34178 was updated. @cmsbuild, @rekovic, @cecilecaillol can you please check and sign again.

[cecilecaillol]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22218c/16142/summary.html
COMMIT: 94c0030
CMSSW: CMSSW_12_0_X_2021-06-20-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34178/16142/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2785631
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2785602
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[cecilecaillol]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1