remove unused KFFittingSmootherESProducer.h

[slava77]

git grep "KFFittingSmootherESProducer\.h" returns nothing

apparently this was supposed to be removed in #11931

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34179/23390

• This PR adds an extra 12KB to repository

[slava77]

@cmsbuild please test

[cmsbuild]

A new Pull Request was created by @slava77 (Slava Krutelyov) for master.

It involves the following packages:

TrackingTools/TrackFitters

@perrotta, @jpata, @slava77 can you please review it and eventually sign? Thanks.
@trocino, @Fedespring, @HuguesBrun, @calderona, @makortel, @felicepantaleo, @abbiendi, @GiacomoSguazzoni, @JanFSchulte, @jhgoh, @VinInn, @bellan, @sscruz, @rovere, @lecriste, @gpetruc, @ebrondol, @mtosi, @dgulhan, @cericeci this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-994807/16101/summary.html
COMMIT: c9a3bcc
CMSSW: CMSSW_12_0_X_2021-06-18-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34179/16101/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• Run3-hcx296 Update some of the cfg's in view of testing SD's to be used #34172 @bsunanda: Run3-hcx296 Update some of the cfg's in view of testing SD's to be used
• Introduce Quality for PixelTracks. Improve Patatrack duplicate & ambiguity resolution #33889 @VinInn: Introduce Quality for PixelTracks. Improve Patatrack duplicate & ambiguity resolution
• Update GEMRECO geometry in online GTs #34165 @francescobrivio: Update GEMRECO geometry in online GTs
• skipPS option for CorrectedECALPFClusterProducer #34134 @hatakeyamak: skipPS option for CorrectedECALPFClusterProducer

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-994807/16101/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-994807/16101/git-merge-result

RelVals-INPUT

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2785631
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2785596
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[slava77]

Failed Tests: RelVals-INPUT

@smuzaffar @mrodozov
do we have some inconsistent error reporting?

I see in https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-994807/16101/runTheMatrixINPUT-results/matrixTestsINPUT.log

Preparing to run 4.26 ZMuSkim2011A+ZMuSkim2011A+HLTDSKIM+RECODR1reHLT+HARVESTDR1reHLT
2021/06/18 15:33:06 ERROR failed to parse X509 proxy: crypto/tls: failed to parse key: asn1: syntax error: sequence truncated

but then the job 4.26 actually completes OK based on the logs

and also the summary of this runTheMatrix test has

603 603 600 561 118 41 3 1 1 tests passed, 0 0 0 0 0 0 0 0 0 failed

+ echo ALL_OK
ALL_OK

Is this X509-related error the reason for the Failed Tests: RelVals-INPUT report?

[smuzaffar]

@slava77 , yes currently bot parses the final log file and look for ERROR keyword in it. If it is there then it marks the test failed.
I see that in this case there are 6 workflows with messages like ERROR failed to parse X509 proxy but test actually ran fine. I can update bot to ignore ERROR failed to parse X509 proxy

[slava77]

+reconstruction

for #34179 c9a3bcc

• technical
• compiles and runs

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1

[qliphy]

merge