New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include new PPS geometry tag and Hcal MC tag in GTs #34218
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34218/23466
|
A new Pull Request was created by @malbouis for master. It involves the following packages: Configuration/AlCa @malbouis, @yuanchao, @cmsbuild, @tlampen, @pohsun, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test parameters:
|
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ab8de1/16180/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
hold |
Pull request has been put on hold by @francescobrivio |
@cms-sw/hcal-dpg-l2 can you confirm the differences observed in the tests are expected from the update of the |
Hi Francesco, yes, these changes are expected, we have relatively large corrections for depth 1. Please see the maps of new/old response corrections here:
Adding @abdoulline to have a look also. |
I've checked the changes (default HcalRespCorrs_2021_v1.0_mc -> HcalRespCorrs_2021_v2.0_mc in new GTs) in 12_0_X using our usual single-pion gun test for 2021 era |
Thank you for the confirmation @mseidel42 and @abdoulline ! |
unhold |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
@qliphy @silviodonato this can be merged at your convenience then. |
+1 |
PR description:
This PR is to update GTs with two new tags:
PPS new geometry tag (in Run-2 data and Run-3 MC GTs), PPSRECO_Geometry_120YV1, as requested in https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4412.html and presented at https://indico.cern.ch/event/1048769/#5-pps-reco-geometry
Hcal new MC tag (in mcRun3 GTs), HcalRespCorrs_2021_v2.0_mc, as requested in https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4414.html
The GT differences are shown below.
Offline data
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_dataRun2_v1/120X_dataRun2_v2
Offline data (HEM failure)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun2_HEfail_v6/120X_dataRun2_HEfail_v1
Offline data relval
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_dataRun2_relval_v1/120X_dataRun2_relval_v2
Prompt-like HI data
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun2_PromptLike_HI_v6/120X_dataRun2_PromptLike_HI_v1
2021 design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun3_2021_design_v1/120X_mcRun3_2021_design_v2
2021 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun3_2021_realistic_v1/120X_mcRun3_2021_realistic_v2
2021 cosmics
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun3_2021cosmics_realistic_deco_v1/120X_mcRun3_2021cosmics_realistic_deco_v2
2021 heavy ion
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun3_2021_realistic_HI_v1/120X_mcRun3_2021_realistic_HI_v2
2023 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun3_2023_realistic_v1/120X_mcRun3_2023_realistic_v2
2024 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun3_2024_realistic_v1/120X_mcRun3_2024_realistic_v2
PR validation:
runTheMatrix.py -j8 -l limited,138.1,138.2,11925 --ibeos
if this PR is a backport please specify the original PR and why you need to backport that PR:
It is not a backport and no backport is expected.