Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include new PPS geometry tag and Hcal MC tag in GTs #34218

Merged
merged 1 commit into from Jun 24, 2021

Conversation

malbouis
Copy link
Contributor

PR description:

This PR is to update GTs with two new tags:

PPS new geometry tag (in Run-2 data and Run-3 MC GTs), PPSRECO_Geometry_120YV1, as requested in https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4412.html and presented at https://indico.cern.ch/event/1048769/#5-pps-reco-geometry

Hcal new MC tag (in mcRun3 GTs), HcalRespCorrs_2021_v2.0_mc, as requested in https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4414.html

The GT differences are shown below.

Offline data
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_dataRun2_v1/120X_dataRun2_v2

Offline data (HEM failure)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun2_HEfail_v6/120X_dataRun2_HEfail_v1

Offline data relval
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_dataRun2_relval_v1/120X_dataRun2_relval_v2

Prompt-like HI data
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun2_PromptLike_HI_v6/120X_dataRun2_PromptLike_HI_v1

2021 design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun3_2021_design_v1/120X_mcRun3_2021_design_v2

2021 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun3_2021_realistic_v1/120X_mcRun3_2021_realistic_v2

2021 cosmics
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun3_2021cosmics_realistic_deco_v1/120X_mcRun3_2021cosmics_realistic_deco_v2

2021 heavy ion
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun3_2021_realistic_HI_v1/120X_mcRun3_2021_realistic_HI_v2

2023 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun3_2023_realistic_v1/120X_mcRun3_2023_realistic_v2

2024 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun3_2024_realistic_v1/120X_mcRun3_2024_realistic_v2

PR validation:

runTheMatrix.py -j8 -l limited,138.1,138.2,11925 --ibeos

if this PR is a backport please specify the original PR and why you need to backport that PR:

It is not a backport and no backport is expected.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34218/23466

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @malbouis for master.

It involves the following packages:

Configuration/AlCa

@malbouis, @yuanchao, @cmsbuild, @tlampen, @pohsun, @francescobrivio can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@malbouis
Copy link
Contributor Author

test parameters:

  • workflow=138.1,138.2,11925.0

@malbouis
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ab8de1/16180/summary.html
COMMIT: 3100f90
CMSSW: CMSSW_12_0_X_2021-06-22-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34218/16180/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-ab8de1/11925.0_GluGluTo2Jets_14TeV+2021PU+GluGluTo2Jets_M_300_2000_14TeV_Exhume_GenSim+DigiPU+RecoPU+HARVESTPU+Nano
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-ab8de1/138.1_RunCosmics2020+RunCosmics2020+RECOCOSDRUN3+ALCACOSDRUN3+HARVESTDCRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-ab8de1/138.2_RunCosmics2020+RunCosmics2020+RECOCOSDEXPRUN3+ALCACOSDEXPRUN3+HARVESTDCEXPRUN3

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 5494 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2785631
  • DQMHistoTests: Total failures: 981
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2784628
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: found differences in 3 / 37 workflows

@yuanchao
Copy link
Contributor

+1

  • new tags for PPS geo and HCal MC
  • matrix tests passed (including 138.1,138.2,11925.0)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@francescobrivio
Copy link
Contributor

hold

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @francescobrivio
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@francescobrivio
Copy link
Contributor

@cms-sw/hcal-dpg-l2 can you confirm the differences observed in the tests are expected from the update of the HcalRespCorrs_2021_v2.0_mc tag?

@mseidel42
Copy link
Contributor

Hi Francesco, yes, these changes are expected, we have relatively large corrections for depth 1.

Please see the maps of new/old response corrections here:

Adding @abdoulline to have a look also.

@abdoulline
Copy link

I've checked the changes (default HcalRespCorrs_2021_v1.0_mc -> HcalRespCorrs_2021_v2.0_mc in new GTs) in 12_0_X using our usual single-pion gun test for 2021 era
https://cms-cpt-software.web.cern.ch/cms-cpt-software/General/Validation/SVSuite/HCAL/calo_scan_single_pi/12_X/12_0_X_run3_RespCorrs_2021_v2.0_mc_vs_12_0_X_run3_SinglePi/
NB: the same result/difference is observed in the (same) test in 12_0_X w/wo this PR.
I believe the observations do correspond to aformentioned (by Markus) change in the conditions.

@francescobrivio
Copy link
Contributor

Thank you for the confirmation @mseidel42 and @abdoulline !

@francescobrivio
Copy link
Contributor

unhold

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@francescobrivio
Copy link
Contributor

@qliphy @silviodonato this can be merged at your convenience then.

@qliphy
Copy link
Contributor

qliphy commented Jun 24, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants