trackingNtuple updates from mkFit/LST developments

[slava77]

these updates accumulated over a couple of years in the mkFit and line-segment tracking (LST) developments.
The default trackingNtuple logic should be the same (aside for a few added branches).

Summary of changes relative to the upstream in TrackingNtuple

• optional for simhits info:
  • can add OOT hits with includeOOT
  • can keep (secondary) electron simhits with keepEleSimHits
  • can save simhit momentum px,py,pz with saveSimHitsP3
  • can enable saving only the closest simhit based on significance sorting with simHitBySignificance
• optional for seed details:
  • can save Curvilinear 5x5 covariance with addSeedCurvCov in a row-major vector of size 15
• added by default:
  • bitmask of cluster masking used per iteration; configurable via clusterMasks
  • cluster charge per CM
  • cluster size
  • seed state parameters in global coordinates (x,y,z and px,py,pz)
• config tools now have customiseTrackingNtupleHLT to be able to run on HLT tracking

Also, add TrackSimpleMerger which can concatenate a set of reco::Track collections.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34256/23539

• This PR adds an extra 124KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34256/23539/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34256/23539/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34256/23540

• This PR adds an extra 96KB to repository

[cmsbuild]

A new Pull Request was created by @slava77 (Slava Krutelyov) for master.

It involves the following packages:

CommonTools/RecoAlgos
Validation/RecoTrack

@perrotta, @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @slava77, @jpata, @rvenditti can you please review it and eventually sign? Thanks.
@rappoccio, @jdolen, @makortel, @felicepantaleo, @abbiendi, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @ahinzmann, @gkasieczka, @jhgoh, @wmtford, @hatakeyamak, @ebrondol, @mtosi, @dgulhan, @clelange this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1d441c/16249/summary.html
COMMIT: be2d604
CMSSW: CMSSW_12_0_X_2021-06-25-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34256/16249/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2785711
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2785682
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[slava77]

@mtosi @vmariani @mmusich
please check the updates.

I see that DQM have signed already, but since I did not discuss the details in this PR explicitly with TRK POG, I wanted to get an OK for the updates.

(this was reviewed/discussed with former TRK POG conveners (@makortel and @cerati ) as a part of developments/needs for mkFit; just to give more context)

[mtosi]

+1, thanks

[slava77]

+reconstruction

for #34256 be2d604

• code changes are primarily in Validation/RecoTrack; the reco category includes only an addition of a plain track merger CommonTools/RecoAlgos/plugins/TrackSimpleMerger.cc
• jenkins tests pass and comparisons with the baseline show no (relevant) differences

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1