Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread Safe Tracking Validation Modules #3427

Merged
merged 9 commits into from Apr 23, 2014
Merged

Thread Safe Tracking Validation Modules #3427

merged 9 commits into from Apr 23, 2014

Conversation

avartak
Copy link
Contributor

@avartak avartak commented Apr 22, 2014

Changes are introduced to make the plugins in Validation/RecoTrack namely MultiTrackValidator and TrackerSeedValidator thread safe

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @avartak for CMSSW_7_1_X.

Thread Safe Tracking Validation Modules

It involves the following packages:

Validation/RecoTrack

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
@cerati, @GiacomoSguazzoni, @rovere this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@danduggan
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@@ -51,7 +51,7 @@ class MultiTrackValidatorBase {

protected:

DQMStore* dbe_;
//DQMStore* dbe_;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not comment code, simply remove it in the next PR you do.

ktf added a commit that referenced this pull request Apr 23, 2014
Multithreading -- Thread Safe Tracking Validation Modules
@ktf ktf merged commit 818b6c4 into cms-sw:CMSSW_7_1_X Apr 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants