HcalDQM - Drop type specs for python files

[lwang046]

PR description:

Drop type specs in DQM/HcalTasks and DQMOffline/Hcal configurations files

PR validation:

runTheMatrix.py -l limited -i all --ibeos test okay

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34278/23580

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @lwang046 for master.

It involves the following packages:

DQM/HcalTasks
DQMOffline/Hcal

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@abdoulline, @DryRun, @rociovilar this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

Thanks a lot for this PR @lwang046
May I ask you to modify also any right hand side assignment? Explicit types on the right hand side should be avoided, like those on lines

cmssw/DQM/HcalTasks/python/OfflineSourceSequence_pp.py

Lines 15 to 22 in df8df18

	digiTask.ptype = cms.untracked.int32(1)
	tpTask.ptype = cms.untracked.int32(1)
	recHitTask.ptype = cms.untracked.int32(1)
	rawTask.ptype = cms.untracked.int32(1)
	recHitPreRecoTask.ptype = cms.untracked.int32(1)
	# set the label for Emulator TP Task
	tpTask.tagEmul = cms.untracked.InputTag("valHcalTriggerPrimitiveDigis")

Thank you!

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34278/23584

• This PR adds an extra 12KB to repository

[cmsbuild]

Pull request #34278 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please check and sign again.

[jfernan2]

Thank you @lwang046
Could you do the same (drop type in every right hand side assignment) for the rest of python files in the package?
Thanks

[lwang046]

Hi @jfernan2 thanks for pointing out the missed ones that needs to be fixed. I tried to go file by file in this package and fixed all files that I can identify except this file which I'm not sure if it needs change: https://github.com/cms-sw/cmssw/blob/master/DQM/HcalTasks/python/HcalQualityTests.py

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34278/23588

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #34278 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please check and sign again.

[jfernan2]

Thanks a lot @lwang046
HcalQualityTests.py seems OK since it is a genuine module declaration, so no real assignments but declarations

[jfernan2]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0ae486/16321/summary.html
COMMIT: 0476d39
CMSSW: CMSSW_12_0_X_2021-06-29-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34278/16321/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2785711
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2785682
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1