Fix SiPixelDigisClustersFromSoA EDM_ML_DEBUG compilation error

[dan131riley]

PR description:

Debug builds of SiPixelDigisClustersFromSoA with EDM_ML_DEBUG fail with this error:

/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/ac2bd627c08c7e1e090dbd2c47050702/opt/cmssw/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_DBG_X_2021-07-01-2300/src/RecoLocalTracker/SiPixelClusterizer/plugins/SiPixelDigisClustersFromSoA.cc: In lambda function:
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/ac2bd627c08c7e1e090dbd2c47050702/opt/cmssw/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_DBG_X_2021-07-01-2300/src/RecoLocalTracker/SiPixelClusterizer/plugins/SiPixelDigisClustersFromSoA.cc:123:57: error: 'cluster' was not declared in this scope; did you mean 'acluster'?
   123 |           << "putting in this cluster " << ic << " " << cluster.charge() << " " << cluster.pixelADC().size();
      |                                                         ^~~~~~~
      |                                                         acluster

This PR fixes compilation. The debug statements were moved wrt std::push_heap as after the heap insertion we no longer know which cluster we just added.

PR validation:

Reproduced the compilation failure. Confirmed that with this fix,

USER_CXXFLAGS="-g -O3 -DEDM_ML_DEBUG" scram b -j32

has no errors. Trivial technical fix, only affects DBG builds.

[dan131riley]

Duplicative (though somewhat different) of #34310, should have re-checked the PR list...

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34317/23657

• This PR adds an extra 12KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoLocalTracker/SiPixelClusterizer/plugins/SiPixelDigisClustersFromSoA.cc modified in PR(s): fix SiPixelDigisClustersFromSoA for DBG IBs #34310

[cmsbuild]

A new Pull Request was created by @dan131riley (Dan Riley) for master.

It involves the following packages:

RecoLocalTracker/SiPixelClusterizer

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@mtosi, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @OzAmram, @ferencek, @dkotlins, @gpetruc, @mmusich, @threus, @tvami this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[VinInn]

This is a solution as well (and more in line with the original debug code)

[slava77]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4867a5/16429/summary.html
COMMIT: f6e86ba
CMSSW: CMSSW_12_0_X_2021-07-02-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34317/16429/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2785711
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2785688
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[slava77]

+reconstruction

for #34317 f6e86ba

• technical
• jenkins tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1