Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug in isDataClass where "class 'classname'" matches end on line not whole line #3433

Merged
merged 1 commit into from Apr 23, 2014
Merged

fix bug in isDataClass where "class 'classname'" matches end on line not whole line #3433

merged 1 commit into from Apr 23, 2014

Conversation

gartung
Copy link
Member

@gartung gartung commented Apr 22, 2014

No description provided.

@gartung
Copy link
Member Author

gartung commented Apr 22, 2014

This can cause a class to be incorrectly identified as a data class if it is member data class 'classname'\n or base class 'classname'\n

@gartung
Copy link
Member Author

gartung commented Apr 22, 2014

Also removing classes.txt* from repo since they are generated every time in the jenkins static analyzer job.

@gartung
Copy link
Member Author

gartung commented Apr 22, 2014

Also removes BareRootGetter override to prevent hooking in FWCore.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_7_1_X.

fix bug in isDataClass where "class 'classname'" matches end on line not whole line

It involves the following packages:

Utilities/StaticAnalyzers

@cmsbuild, @Degano, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Apr 23, 2014
Framework -- Fix bug in isDataClass where "class 'classname'" matches end on line not whole line
@ktf ktf merged commit adc2cd9 into cms-sw:CMSSW_7_1_X Apr 23, 2014
@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants