Use gain dependent ToT thresholds for HGC digitization

[ttrk]

PR description:

The time-over-threshold mode is enabled depending on the gain parameter applied for the sensor. See [1] for the impact of changes.

[1] : https://indico.cern.ch/event/1049055/contributions/4409458/attachments/2265641/3846729/210616_HGC_DPG_dynamic_ADC_TOT.pdf

PR validation:

Passed WF 23234.103 in 12_0_0_pre3.

@pfs

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34330/23687

• This PR adds an extra 28KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34330/23687/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34330/23687/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34330/23688

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @ttrk (Kaya Tatar) for master.

It involves the following packages:

SimCalorimetry/HGCalSimAlgos
SimCalorimetry/HGCalSimProducers

@mdhildreth, @cmsbuild, @civanch, @srimanob, @kpedro88 can you please review it and eventually sign? Thanks.
@vandreev11, @sethzenz, @bsunanda, @makortel, @rovere, @lgray, @cseez, @apsallid, @pfs, @hatakeyamak this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34330/23693

• This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34330/23693/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34330/23693/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34330/23695

• This PR adds an extra 28KB to repository

[cmsbuild]

Pull request #34330 was updated. @mdhildreth, @cmsbuild, @civanch, @srimanob, @kpedro88 can you please check and sign again.

[srimanob]

Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b6a6ef/16471/summary.html
COMMIT: e836671
CMSSW: CMSSW_12_0_X_2021-07-05-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34330/16471/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2785924
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2785895
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1