Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMTF Emulator Update to Add Run 3 CSC TP variables #34334

Merged
merged 5 commits into from Jul 6, 2021

Conversation

eyigitba
Copy link
Contributor

@eyigitba eyigitba commented Jul 5, 2021

PR description:

This PR adds support for Run 3 CSC TP variables in EMTF, mostly based on examples by @dildick . The CCLUT algorithm is currently not turned on in CSC TP emulator, so this will stay disabled on EMTF side as well. Therefore we expect no changes after this PR for now. The functionality will be turned on once everything is ready on CSC and EMTF side.

  • Modified EMTFHit, EMTFTrack, and MuonTriggerPrimitive data formats to add the new parameters.
  • Modified EMTF PrimitiveConversion to use new variables when they are enabled
  • Added a flag in simEmtfDigis to enable/disable the functionality. For now keeping the flag as False will be turned on depending era in the future.

PR validation:

Validated with:

  • scram b runtests
  • runTheMatrix.py -l limited -i all --ibeos

Notifications: @jiafulow @dildick

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2021

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34334/23696

  • This PR adds an extra 64KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34334/23700

  • This PR adds an extra 64KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2021

A new Pull Request was created by @eyigitba for master.

It involves the following packages:

DataFormats/L1TMuon
L1Trigger/L1TMuon
L1Trigger/L1TMuonEndCap

@cmsbuild, @rekovic, @cecilecaillol can you please review it and eventually sign? Thanks.
@dinyar, @Martin-Grunewald, @rovere, @thomreis this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cecilecaillol
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a406a5/16483/summary.html
COMMIT: cbbe31f
CMSSW: CMSSW_12_0_X_2021-07-05-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34334/16483/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2785924
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2785901
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@cecilecaillol
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jul 6, 2021

+1

@cmsbuild cmsbuild merged commit 0fe0540 into cms-sw:master Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants