Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop type specs in modifiers under Validation/RecoParticleFlow and some cleanup #34339

Merged
merged 2 commits into from Jul 6, 2021

Conversation

hatakeyamak
Copy link
Contributor

@hatakeyamak hatakeyamak commented Jul 5, 2021

PR description:

This PR drops type specs in Validation/RecoParticleFlow. It also removes some obsolete files which we think are not longer used.

Also, I used this opportunity to clean-up folder naming/organization a little bit.

RecoParticleFlow/SlimmedMuonValidation
->
RecoParticleFlow/slimmedMuonValidation

and

RecoParticleFlow/ElectronValidation/JetPtRes
->
RecoParticleFlow/PFJetValidation/JetPtRes

PR validation:

cd runTheMatrix.py -l limited seems to run ok.

if this PR is a backport please specify the original PR and why you need to backport that PR:

not backport.

@juska @bendavid @kdlong

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34339/23708

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2021

A new Pull Request was created by @hatakeyamak (Kenichi Hatakeyama) for master.

It involves the following packages:

Validation/RecoParticleFlow

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@hatakeyamak hatakeyamak changed the title Drop type specs in Validation/RecoParticleFlow and some cleanup Drop type specs in modifiers under Validation/RecoParticleFlow and some cleanup Jul 5, 2021
@jfernan2
Copy link
Contributor

jfernan2 commented Jul 5, 2021

Thanks for this cleanup @hatakeyamak !

@jfernan2
Copy link
Contributor

jfernan2 commented Jul 5, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3a4787/16477/summary.html
COMMIT: e47f41e
CMSSW: CMSSW_12_0_X_2021-07-05-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34339/16477/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2784784
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2784761
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): -261.354 KiB ParticleFlow/SlimmedMuonValidation
  • DQMHistoSizes: changed ( 10024.0,... ): 261.354 KiB ParticleFlow/slimmedMuonValidation
  • DQMHistoSizes: changed ( 10024.0,... ): 60.736 KiB ParticleFlow/PFJetResValidation
  • DQMHistoSizes: changed ( 10024.0,... ): -60.736 KiB ParticleFlow/ElectronValidation
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

#muonPFsequenceMC.inputTagMuonReco = cms.InputTag('muons')
#muonPFsequenceMC.inputTagGenParticles = cms.InputTag('slimmedMuons')
slimmedMuonValidation1 = pfMuonDQMAnalyzer.clone(
BenchmarkLabel = 'slimmedMuonValidation/CompWithRecoMuons',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hatakeyamak just to confirm: Slimmed -> slimmed is intentional and not a typo, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's intentional, as all other 'slimmed` folder started with a lower case.
I added it in the PR description.

@jfernan2
Copy link
Contributor

jfernan2 commented Jul 6, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jul 6, 2021

+1

@cmsbuild cmsbuild merged commit 9bfce94 into cms-sw:master Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants