New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop type specs in modifiers under Validation/RecoParticleFlow and some cleanup #34339
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34339/23708
|
A new Pull Request was created by @hatakeyamak (Kenichi Hatakeyama) for master. It involves the following packages: Validation/RecoParticleFlow @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Thanks for this cleanup @hatakeyamak ! |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3a4787/16477/summary.html Comparison SummarySummary:
|
#muonPFsequenceMC.inputTagMuonReco = cms.InputTag('muons') | ||
#muonPFsequenceMC.inputTagGenParticles = cms.InputTag('slimmedMuons') | ||
slimmedMuonValidation1 = pfMuonDQMAnalyzer.clone( | ||
BenchmarkLabel = 'slimmedMuonValidation/CompWithRecoMuons', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hatakeyamak just to confirm: Slimmed -> slimmed is intentional and not a typo, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's intentional, as all other 'slimmed` folder started with a lower case.
I added it in the PR description.
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR drops type specs in Validation/RecoParticleFlow. It also removes some obsolete files which we think are not longer used.
Also, I used this opportunity to clean-up folder naming/organization a little bit.
and
PR validation:
cd runTheMatrix.py -l limited
seems to run ok.if this PR is a backport please specify the original PR and why you need to backport that PR:
not backport.
@juska @bendavid @kdlong