fix definition override in RecoTrackerP5_cff.py [11_3_X]

[mmusich]

backport of #34332

PR description:

PR #30947 appears to have broken a functionality used in the tracker alignment group.
The following code snippet:

import FWCore.ParameterSet.Config as cms
process = cms.Process("MuonTrackSplit")

import Alignment.CommonAlignment.tools.trackselectionRefitting as trackselRefit
process.seqTrackselRefit = trackselRefit.getSequence(process,
                                                     "ALCARECOTkAlCosmicsCTF0T",
                                                     isPVValidation = False, 
                                                     TTRHBuilder = "WithAngleAndTemplate",
                                                     usePixelQualityFlag=True,
                                                     openMassWindow = False,
                                                     cosmicsDecoMode = True,
                                                     cosmicsZeroTesla = False,
                                                     momentumConstraint = None,
                                                     cosmicTrackSplitting = True,
                                                     use_d0cut = False
                                                     )

currently results in:

ValueError: Trying to override definition of cosmicTrackSplitter while it is used by the task cosmictracksP5Task
 new object defined in: /tmp/musich/CMSSW_12_0_X_2021-07-05-1100/python/RecoTracker/FinalTrackSelectors/cosmicTrackSplitter_cfi.py
 existing object defined in: /tmp/musich/CMSSW_12_0_X_2021-07-05-1100/python/RecoTracker/Configuration/RecoTrackerP5_cff.py

This PR fixes the issue reported above.

PR validation:

Run the code snippet above successfully:

cmsRun testTrackRefiter.py

if this PR is a backport please specify the original PR and why you need to backport that PR:

backport of #34332

cc:
@DaveBrun94

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_11_3_X.

It involves the following packages:

RecoTracker/Configuration
RecoTracker/FinalTrackSelectors

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @ebrondol, @gpetruc, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from fix definition override in RecoTrackerP5_cff.py #34332

[mmusich]

@cmsbuild, please test

[mmusich]

type bug-fix

[mmusich]

urgent

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dabd3b/16489/summary.html
COMMIT: bcd896b
CMSSW: CMSSW_11_3_X_2021-07-05-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34347/16489/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2877978
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2877955
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[perrotta]

+reconstruction

• Identical to fix definition override in RecoTrackerP5_cff.py #34332, now merged in master
• It fixes an error in the configuration of the cosmicTrackSplitter in RecoTrackerP5_cff.py
• Jenkins tests pass and show no differences in the standard workflows, as this PR only affects a tracker alignment workflow to be used online (verified to get fixed, as reported in the master PR description)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1