Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utilities/StaticAnalyzers: Update generation of EventSetupRecord::get report. #34389

Merged
merged 1 commit into from Jul 16, 2021
Merged

Utilities/StaticAnalyzers: Update generation of EventSetupRecord::get report. #34389

merged 1 commit into from Jul 16, 2021

Conversation

gartung
Copy link
Member

@gartung gartung commented Jul 7, 2021 •
edited

Update script for generating ESR::get report.
Update regex used for finding top level functions and ESR::get function calls.
Update module_to_package.yaml with mapping used in circles graph
Check if the module is in modules_in_ib.txt

Verified that report generated by the script has expected modules in it.

@cmsbuild cmsbuild added this to the CMSSW_12_0_X milestone Jul 7, 2021
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34389/23781

  • This PR adds an extra 40KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2021

A new Pull Request was created by @gartung (Patrick Gartung) for master.

It involves the following packages:

Utilities/StaticAnalyzers (core)

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34389/23802

  • This PR adds an extra 52KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2021

Pull request #34389 was updated. @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34389/23805

  • This PR adds an extra 52KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2021

Pull request #34389 was updated. @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34389/23818

  • This PR adds an extra 52KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2021

Pull request #34389 was updated. @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please check and sign again.

@gartung
Squashed commit of the following:
5246a91 
Use module to package mapping from Circles packages.json

commit c500be747024bda314423c91a5b536d0e81e1c37
Author: Patrick Gartung <gartung@fnal.gov>
Date:   Wed Jul 14 21:40:21 2021 +0200

    Make edm:: optional for DQMOneEDAnalyzer

commit 7db7bca
Author: Patrick Gartung <gartung@fnal.gov>
Date:   Wed Jul 14 20:24:01 2021 +0200

    Remove top function part of baseclass regex

commit c218b2f
Author: Patrick Gartung <gartung@fnal.gov>
Date:   Wed Jul 14 20:19:01 2021 +0200

    Remove PFTauPrimaryVertexProducerBase from modules_in_ib.txt

commit 74b8a5a
Author: Patrick Gartung <gartung@fnal.gov>
Date:   Wed Jul 14 20:01:35 2021 +0200

    edm:: should always be first namespace of edm base classes. Add optional virtual to base functions. Add impl::RunWatcher impl::RunCacheHolder

commit ca3787e
Author: Patrick Gartung <gartung@fnal.gov>
Date:   Wed Jul 14 18:33:51 2021 +0200

    Remove debug prints. Baseclass regex include function.

commit 58f0b7a
Author: Patrick Gartung <gartung@fnal.gov>
Date:   Wed Jul 14 18:04:40 2021 +0200

    Remove modules that appear with namespace prefix

commit ed74b9f
Author: Patrick Gartung <gartung@fnal.gov>
Date:   Wed Jul 14 02:00:27 2021 +0200

    Add PFTauPrimaryVertexProducerBase to modules_in_ib.txt

commit 3db470e
Author: Patrick Gartung <gartung@fnal.gov>
Date:   Wed Jul 14 01:36:51 2021 +0200

    Only match ESR::get with string as first arg

commit bae666a
Author: Patrick Gartung <gartung@fnal.gov>
Date:   Wed Jul 14 01:22:58 2021 +0200

    Add \b to module name search expression to avoid partial name matches

commit 272f14c
Author: Patrick Gartung <gartung@fnal.gov>
Date:   Fri Jul 9 21:26:22 2021 +0200

    Remove duplicate keys

commit da185fa
Author: Patrick Gartung <gartung@fnal.gov>
Date:   Fri Jul 9 05:33:43 2021 +0200

    Skip get call with const char *, edm:ESHandle<> args

commit a3b3a75
Author: Patrick Gartung <gartung@fnal.gov>
Date:   Fri Jul 9 00:45:07 2021 +0200

    Update regex. Make yaml fields inf wide.

commit bd905cd
Author: Patrick Gartung <gartung@fnal.gov>
Date:   Thu Jul 8 23:01:51 2021 +0200

    Account for ESTransientHandle

commit 6df3623
Author: Patrick Gartung <gartung@fnal.gov>
Date:   Thu Jul 8 22:55:03 2021 +0200

    Remove module duplicates. Use more general regex for ESRget

commit 6b960a7
Author: Patrick Gartung <gartung@fnal.gov>
Date:   Thu Jul 8 16:58:45 2021 +0200

    Remove debug print statement.

commit b0b4daa
Author: Patrick Gartung <gartung@fnal.gov>
Date:   Thu Jul 8 16:31:19 2021 +0200

    Add modules with namespace prefix. Update static analyzer script.

commit 8bbe5bf
Author: Patrick Gartung <gartung@fnal.gov>
Date:   Wed Jul 7 21:12:36 2021 +0200

    Check if the module is in modules_in_ib.txt

commit 533e372
Author: Patrick Gartung <gartung@fnal.gov>
Date:   Wed Jul 7 20:47:05 2021 +0200

        Utilities/StaticAnayzers: Update script for generating ESR::get report.
        Update regex used for finding top level functions and ESR::get function calls.
        Update module_to_package.yaml with mapping used in circles graph
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34389/23994

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

Pull request #34389 was updated. @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please check and sign again.

@makortel
Copy link
Contributor

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15cdd0/16864/summary.html
COMMIT: 5246a91
CMSSW: CMSSW_12_0_X_2021-07-15-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34389/16864/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2786302
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2786279
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jul 16, 2021

+1

@cmsbuild cmsbuild merged commit d229e5d into cms-sw:master Jul 16, 2021
This was referenced Jul 16, 2021
Merged
Merged
Closed
Closed
@gartung gartung deleted the gartung-SA-esr-get-update branch December 1, 2021 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved core-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_12_0_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gartung @cmsbuild @makortel @qliphy