Introduce `conddb` script unit tests #34392

mmusich · 2021-07-08T09:02:39Z

PR description:

This is inspired from #34378.
In commit 0daa900 a unit test to check basic functionalities of the conddb script is added.
In commit 2927fc9 a protection for conddb diffGlobalTagsAtRun is added, in order not go in error if it's run=1 (that's MC)

PR validation:

The newly introduced unit test passes:

scram b runtests_test_conddb

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

cmsbuild · 2021-07-08T09:08:31Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34392/23787

This PR adds an extra 44KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File CondCore/Utilities/test/BuildFile.xml modified in PR(s): introduce uploadConditions.py unit test #34379

cmsbuild · 2021-07-08T09:08:58Z

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

CondCore/Utilities (db)

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

mmusich · 2021-07-08T09:10:18Z

@cmsbuild, please test

cmsbuild · 2021-07-08T12:36:56Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-892eb1/16590/summary.html
COMMIT: 10ec355
CMSSW: CMSSW_12_0_X_2021-07-07-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34392/16590/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 5120 differences found in the comparisons
DQMHistoTests: Total files compared: 38
DQMHistoTests: Total histograms compared: 2786260
DQMHistoTests: Total failures: 12
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2786225
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 160 log files, 37 edm output root files, 38 DQM output files
TriggerResults: no differences found

cmsbuild · 2021-07-09T08:13:50Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34392/23830

This PR adds an extra 40KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File CondCore/Utilities/scripts/conddb modified in PR(s): Moving conddb tools to python3 #34402
- File CondCore/Utilities/test/BuildFile.xml modified in PR(s): introduce uploadConditions.py unit test #34379

cmsbuild · 2021-07-09T08:14:09Z

Pull request #34392 was updated. @ggovi, @cmsbuild can you please check and sign again.

qliphy · 2021-07-20T10:13:11Z

please test

cmsbuild · 2021-07-21T02:18:38Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-892eb1/17014/summary.html
COMMIT: 4cc9355
CMSSW: CMSSW_12_0_X_2021-07-19-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34392/17014/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-892eb1/17014/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-892eb1/17014/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test EcalDAQ_O2O_test had ERRORS
---> test EcalDCS_O2O_test had ERRORS
---> test EcalLaser_O2O_test had ERRORS

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 2996268
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2996245
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

mmusich · 2021-07-21T07:25:40Z

test parameters:

mmusich · 2021-07-21T07:25:55Z

@cmsbuild, please test

cmsbuild · 2021-07-21T10:39:48Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-892eb1/17045/summary.html
COMMIT: 4cc9355
CMSSW: CMSSW_12_0_X_2021-07-20-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34392/17045/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 2996268
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2996239
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

mmusich · 2021-07-21T10:41:54Z

Can we please merge this before the release gets broken in 10,000 other ways? Thanks

davidlange6 · 2021-07-21T10:58:17Z

Having just waited 2 weeks for a simple db PR (whose absence broke the second round of your PR tests), I guess this PR is still too young to be signed:)

…

On Jul 21, 2021, at 12:42 PM, Marco Musich ***@***.***> wrote: Can we please merge this before the release gets broken in 10,000 other ways? Thanks — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

ggovi · 2021-07-21T12:13:02Z

+1

cmsbuild · 2021-07-21T12:13:26Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-07-21T12:37:35Z

+1

cmsbuild added this to the CMSSW_12_0_X milestone Jul 8, 2021

cmsbuild added code-checks-pending db-pending orp-pending pending-signatures tests-pending labels Jul 8, 2021

mmusich mentioned this pull request Jul 8, 2021

several conddb tools broken in recent 12_0_X IBs #34378

Closed

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 8, 2021

cmsbuild added tests-started and removed tests-pending labels Jul 8, 2021

cmsbuild mentioned this pull request Jul 8, 2021

introduce uploadConditions.py unit test #34379

Merged

cmsbuild added tests-approved and removed tests-started labels Jul 8, 2021

cmsbuild mentioned this pull request Jul 8, 2021

Moving conddb tools to python3 #34402

Merged

mmusich force-pushed the fixSomeCondDBFailures branch from 10ec355 to e2d1f46 Compare July 9, 2021 08:00

cmsbuild added code-checks-pending tests-pending and removed code-checks-approved tests-approved labels Jul 9, 2021

mmusich force-pushed the fixSomeCondDBFailures branch from e2d1f46 to 0daa900 Compare July 9, 2021 08:06

mmusich changed the title ~~Fix some conddb failures~~ Introduce conddb script unit tests Jul 9, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 9, 2021

cmsbuild added tests-started and removed tests-rejected labels Jul 20, 2021

cmsbuild added tests-rejected and removed tests-started labels Jul 21, 2021

cmsbuild added tests-started and removed requires-external tests-rejected labels Jul 21, 2021

cmsbuild added tests-approved and removed tests-started labels Jul 21, 2021

cmsbuild added db-approved fully-signed and removed db-pending pending-signatures labels Jul 21, 2021

cmsbuild added orp-approved and removed orp-pending labels Jul 21, 2021

cmsbuild merged commit c10bab1 into cms-sw:master Jul 21, 2021

mmusich deleted the fixSomeCondDBFailures branch July 21, 2021 12:42

This was referenced Jul 21, 2021

scram-tools repo to provide scram toolfile definitions cms-sw/cmsdist#7147

Merged

support global::OutputModule<ExternalWork> #34579

Merged

Remove EventSetup use from PdtEntry #34581

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce `conddb` script unit tests #34392

Introduce `conddb` script unit tests #34392

mmusich commented Jul 8, 2021 •

edited

cmsbuild commented Jul 8, 2021

cmsbuild commented Jul 8, 2021

mmusich commented Jul 8, 2021

cmsbuild commented Jul 8, 2021

cmsbuild commented Jul 9, 2021

cmsbuild commented Jul 9, 2021

qliphy commented Jul 20, 2021

cmsbuild commented Jul 21, 2021

mmusich commented Jul 21, 2021

mmusich commented Jul 21, 2021

cmsbuild commented Jul 21, 2021

mmusich commented Jul 21, 2021

davidlange6 commented Jul 21, 2021 via email

ggovi commented Jul 21, 2021

cmsbuild commented Jul 21, 2021

qliphy commented Jul 21, 2021

Introduce conddb script unit tests #34392

Introduce conddb script unit tests #34392

Conversation

mmusich commented Jul 8, 2021 • edited

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Jul 8, 2021

cmsbuild commented Jul 8, 2021

mmusich commented Jul 8, 2021

cmsbuild commented Jul 8, 2021

Comparison Summary

cmsbuild commented Jul 9, 2021

cmsbuild commented Jul 9, 2021

qliphy commented Jul 20, 2021

cmsbuild commented Jul 21, 2021

Unit Tests

Comparison Summary

mmusich commented Jul 21, 2021

mmusich commented Jul 21, 2021

cmsbuild commented Jul 21, 2021

Comparison Summary

mmusich commented Jul 21, 2021

davidlange6 commented Jul 21, 2021 via email

ggovi commented Jul 21, 2021

cmsbuild commented Jul 21, 2021

qliphy commented Jul 21, 2021

Introduce `conddb` script unit tests #34392

Introduce `conddb` script unit tests #34392

mmusich commented Jul 8, 2021 •

edited