Added WaitingTask Chain

[Dr15Jones]

PR description:

Make it easier to create a chain of WaitingTasks to be run in sequence.

It is now possible to specify the tasks in the order in which they should be run, rather than in reverse order. Works with existing functions that expected to be given a edm::WaitingTaskHolder.

PR validation:

New unit test and all framework unit tests pass.

[Dr15Jones]

NOTE: this is just a refactoring so should have no effect on behavior.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34413/23819

• This PR adds an extra 36KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File FWCore/Framework/src/EventProcessor.cc modified in PR(s): Implement persistence for ProcessBlock products #33969

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

• FWCore/Concurrency (core)
• FWCore/Framework (core)

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

-1

Failed Tests: ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bbd486/16629/summary.html
COMMIT: e267bd0
CMSSW: CMSSW_12_0_X_2021-07-08-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34413/16629/install.sh to create a dev area with all the needed externals and cmssw changes.

Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34413/23824

• This PR adds an extra 36KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File FWCore/Framework/src/EventProcessor.cc modified in PR(s): Implement persistence for ProcessBlock products #33969

[cmsbuild]

Pull request #34413 was updated. @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please check and sign again.

[makortel]

@cmsbuild, please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34413/24122

• This PR adds an extra 20KB to repository

• Found files with invalid states:

  • FWCore/Concurrency/interface/beginChain.h:
    • Added: 0364f8e
    • Modified: 806d33d, 025f581
    • Deleted: a72849d
  • FWCore/Concurrency/interface/beginWaitingTaskChain.h:
    • Added: b23cd99
    • Modified: c55fe89
    • Deleted: 0364f8e

[cmsbuild]

Pull request #34413 was updated. @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please check and sign again.

[Dr15Jones]

please test

it was only a comment change, but what the hey

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bbd486/17060/summary.html
COMMIT: d24754d
CMSSW: CMSSW_12_0_X_2021-07-20-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34413/17060/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 136.732136.732_RunZeroBias2016B+RunZeroBias2016B+HLTDR2_2016+RECODR2_2016reHLT_ZB_HIPM+HARVESTDR2ZB/step2_RunZeroBias2016B+RunZeroBias2016B+HLTDR2_2016+RECODR2_2016reHLT_ZB_HIPM+HARVESTDR2ZB.log
• 136.726136.726_RunMuonEG2016B+RunMuonEG2016B+HLTDR2_2016+RECODR2_2016reHLT_skimMuonEG_HIPM+HARVESTDR2/step2_RunMuonEG2016B+RunMuonEG2016B+HLTDR2_2016+RECODR2_2016reHLT_skimMuonEG_HIPM+HARVESTDR2.log
• 136.721136.721_RunHLTPhy2016B+RunHLTPhy2016B+HLTDR2_2016+RECODR2_2016reHLT_HIPM+HARVESTDR2/step2_RunHLTPhy2016B+RunHLTPhy2016B+HLTDR2_2016+RECODR2_2016reHLT_HIPM+HARVESTDR2.log

Expand to see more relval errors ...

• 136.722
• 136.723
• 136.724
• 136.725
• 136.727
• 136.728
• 136.729
• 136.73
• 136.731
• 136.735
• 136.734
• 136.72411
• 136.733

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

• No significant changes to the logs found
• Reco comparison results: 1222 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2996268
• DQMHistoTests: Total failures: 3672
• DQMHistoTests: Total nulls: 19
• DQMHistoTests: Total successes: 2992555
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 45.703 KiB( 38 files compared)
• DQMHistoSizes: changed ( 140.53 ): 44.531 KiB Hcal/DigiRunHarvesting
• DQMHistoSizes: changed ( 140.53 ): 1.172 KiB RPC/DCSInfo
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[makortel]

Comparison differences are all in 140.53 that had different input file compared to IB. The RelVals-INPUT appear to be all

A fatal system signal has occurred: external termination request
The following is the call stack containing the origin of the signal.

so were the jobs killed because of timeout?

[makortel]

+1

Earlier tests succeeded fine, the change was only in a comment.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

merge