Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate MultiTrackSelector to EventSetup consumes #34416

Merged
merged 2 commits into from Jul 12, 2021

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Jul 9, 2021

PR description:

Something that looked simple to do while I looked the class for other reasons. Part of #31061. Resolves cms-sw/framework-team#184.

PR validation:

Code compiles.

@makortel
Copy link
Contributor Author

makortel commented Jul 9, 2021

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34416/23826

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2021

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

  • RecoTracker/FinalTrackSelectors (reconstruction)

@perrotta, @jpata, @slava77 can you please review it and eventually sign? Thanks.
@felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @ebrondol, @gpetruc, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b906f/16632/summary.html
COMMIT: f740078
CMSSW: CMSSW_12_0_X_2021-07-08-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34416/16632/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 5147 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2786260
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2786237
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@slava77
Copy link
Contributor

slava77 commented Jul 12, 2021

+reconstruction

for #34416 f740078

  • code changes are technical, in line with the PR description
  • jenkins tests pass and comparisons with the baseline show no relevant differences

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jul 12, 2021

+1

@cmsbuild cmsbuild merged commit 4381f40 into cms-sw:master Jul 12, 2021
@makortel makortel deleted the esconsumesMultiTrackSelector branch July 12, 2021 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate some EDModules to esConsumes
4 participants