New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup Thread.isAlive() which has been removed in python 3.9 and avbove #34421
Conversation
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34421/23832
|
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master. It involves the following packages:
@smuzaffar, @andrius-k, @Dr15Jones, @jordan-martins, @makortel, @kmaeshima, @wajidalikhan, @ErnestaP, @kpedro88, @chayanit, @srimanob, @jfernan2, @ahmad3213, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-52a339/16642/summary.html Comparison SummarySummary:
|
+1 |
+core |
@qliphy @silviodonato , can you please merge this so that we can proceed with python 3.9 in devel Ibs |
+Upgrade |
merge |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
AddOnTests
andRelvals
failed forPython 3.9
( DEVEL IBs cms-sw/cmsdist#7111 ) with errors like [a].Thread.isAlive()
has been removed frompython 3.9
( https://bugs.python.org/issue37804 ). This PR replacesisAlive
withis_alive
as suggested here https://bugs.python.org/issue35283[a]