Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Thread.isAlive() which has been removed in python 3.9 and avbove #34421

Merged
merged 1 commit into from Jul 9, 2021
Merged

Cleanup Thread.isAlive() which has been removed in python 3.9 and avbove #34421

merged 1 commit into from Jul 9, 2021

Conversation

smuzaffar
Copy link
Contributor

AddOnTests and Relvals failed for Python 3.9 ( DEVEL IBs cms-sw/cmsdist#7111 ) with errors like [a]. Thread.isAlive() has been removed from python 3.9 ( https://bugs.python.org/issue37804 ). This PR replaces isAlive with is_alive as suggested here https://bugs.python.org/issue35283

[a]

  File "/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7111/16624/CMSSW_12_0_DEVEL_X_2021-07-07-2300/python/Configuration/PyReleaseValidation/MatrixRunner.py", line 26, in activeThreads
    if t.isAlive() : nActive += 1
AttributeError: 'WorkFlowRunner' object has no attribute 'isAlive'

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34421/23832

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2021

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • DQM/Integration (dqm)
  • Utilities/ReleaseScripts (core)

@smuzaffar, @andrius-k, @Dr15Jones, @jordan-martins, @makortel, @kmaeshima, @wajidalikhan, @ErnestaP, @kpedro88, @chayanit, @srimanob, @jfernan2, @ahmad3213, @rvenditti can you please review it and eventually sign? Thanks.
@batinkov, @battibass, @makortel, @wddgit, @Martin-Grunewald, @threus, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-52a339/16642/summary.html
COMMIT: cc9af5a
CMSSW: CMSSW_12_0_X_2021-07-08-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34421/16642/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 5077 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2786260
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2786237
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

jfernan2 commented Jul 9, 2021

+1

@smuzaffar
Copy link
Contributor Author

+core

@smuzaffar
Copy link
Contributor Author

@qliphy @silviodonato , can you please merge this so that we can proceed with python 3.9 in devel Ibs

@srimanob
Copy link
Contributor

srimanob commented Jul 9, 2021

+Upgrade

@qliphy
Copy link
Contributor

qliphy commented Jul 9, 2021

merge

@cmsbuild cmsbuild merged commit 123c40d into cms-sw:master Jul 9, 2021
@chayanit
Copy link

chayanit commented Jul 9, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants