Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DetectorDescription: use python3 in unit test #34472

Merged
merged 1 commit into from Jul 14, 2021
Merged

DetectorDescription: use python3 in unit test #34472

merged 1 commit into from Jul 14, 2021

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Jul 13, 2021

This is needed in order to drop the next set of python2 based modules ( cms-sw/cmsdist#7112 )
These are technical changes and should not break any thing as unit tests are working in PY3 IBs where python is python3.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34472/23925

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

  • DetectorDescription/RegressionTest (geometry)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth can you please review it and eventually sign? Thanks.
@fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Failed Tests: AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b34ba0/16781/summary.html
COMMIT: 70226c3
CMSSW: CMSSW_12_0_X_2021-07-13-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34472/16781/install.sh to create a dev area with all the needed externals and cmssw changes.

AddOn Tests

----- Begin Fatal Exception 13-Jul-2021 21:08:29 CEST-----------------------
An exception of category 'EventCorruption' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'L1TAnalyzerEndpath'
   [2] Prefetching for module L1TGlobalSummary/'L1TGlobalSummary'
   [3] Prefetching for module L1TGlobalProducer/'simGtStage2Digis'
   [4] Prefetching for module L1TStage2Layer2Producer/'simCaloStage2Digis'
   [5] Prefetching for module L1TCaloLayer1/'simCaloStage2Layer1Digis'
   [6] Prefetching for module EcalTrigPrimProducer/'simEcalTriggerPrimitiveDigis'
   [7] Prefetching for module MixingModule/'mix'
   [8] Calling method for module OscarMTProducer/'g4SimHits'
Exception Message:
SimG4CoreApplication exception in generation of event run: 1 lumi: 1 event: 1 in stream 0 

-------- EEEE ------- G4Exception-START -------- EEEE -------
*** G4Exception : InvalidCondition
      issued by : ParticlesWorspacePool::CreateWorkspace()
Cannot create workspace twice for the same thread.
-------- EEEE -------- G4Exception-END --------- EEEE -------
----- End Fatal Exception -------------------------------------------------

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2786302
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2786279
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor Author

@cms-sw/geometry-l2 can you please review and sign it?
@qliphy , @silviodonato , @perrotta this is just a technical update and should be safe to merge.

@smuzaffar
Copy link
Contributor Author

please test
test addOn test failure is not related to this PR ( is there in IB and has been fixed by #34479)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b34ba0/16813/summary.html
COMMIT: 70226c3
CMSSW: CMSSW_12_0_X_2021-07-13-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34472/16813/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2786302
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2786267
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@cvuosalo
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 97e9931 into cms-sw:master Jul 14, 2021
@smuzaffar smuzaffar deleted the py3-fix-DetectorDescription branch July 15, 2021 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants