Configurations and analyzer module to unpack and analyze B904 GEM trigger data

[dildick]

PR description:

Configurations and analyzer module to unpack and analyze GEM trigger data from the B904 GEM-CSC test stand.

PR validation:

Tested on recent local runs. There shouldn't be any changes to any WFs.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34478/23932

• This PR adds an extra 36KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34478/23932/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34478/23932/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34478/23933

• This PR adds an extra 36KB to repository

[cmsbuild]

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

• DQM/L1TMonitor (dqm)
• EventFilter/GEMRawToDigi (reconstruction)
• EventFilter/Utilities (daq, reconstruction)
• IORawData/CSCCommissioning (daq)
• L1Trigger/CSCTriggerPrimitives (l1)
• L1Trigger/L1TGEM (l1)

@perrotta, @andrius-k, @kmaeshima, @emeschi, @ErnestaP, @ahmad3213, @smorovic, @cmsbuild, @rekovic, @jfernan2, @slava77, @jpata, @cecilecaillol, @rvenditti can you please review it and eventually sign? Thanks.
@jshlee, @ptcox, @valuev, @watson-ij, @Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

[smorovic]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d0d64e/16791/summary.html
COMMIT: 08b416c
CMSSW: CMSSW_12_0_X_2021-07-13-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34478/16791/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2786302
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2786279
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[perrotta]

Strange. I can't seem to reproduce the error.

@dildick the same error is present also in the IB, since CMSSW_12_0_X_2021-07-16-2300 at least, and therefore it is not due to this PR.

@cms-sw/dqm-l2 are you already looking at it?

[jfernan2]

It looks to me the same as #34520 and it is being fixed in #34532

[jfernan2]

please test

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d0d64e/17006/summary.html
COMMIT: 09e58db
CMSSW: CMSSW_12_0_X_2021-07-19-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34478/17006/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test TestDQMServicesDemo had ERRORS

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2996268
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2996245
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[smorovic]

+1

[slava77]

+reconstruction

for #34478 09e58db

• code changes in reco category packages are only in EventFilter/GEMRawToDigi/test/ and look reasonable given the PR description. reco production/standard sequences are not affected
• jenkins tests pass and comparisons with the baseline show no differences

[dildick]

@cecilecaillol Could you sign, please? There is a DQM unit test (TestDQMServicesDemo) that failed, but it is unrelated to this PR. Thanks!

[cecilecaillol]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

[perrotta]

merge